Skip to content

Add Maven Build Cache plugin #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Maven Build Cache plugin #4919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .mvn/extensions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,9 @@
<artifactId>maven-profiler</artifactId>
<version>3.2</version>
</extension>
<extension>
<groupId>org.apache.maven.extensions</groupId>
<artifactId>maven-build-cache-extension</artifactId>
<version>1.2.1</version>
</extension>
</extensions>
34 changes: 34 additions & 0 deletions .mvn/maven-build-cache-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<cache xmlns="http://maven.apache.org/BUILD-CACHE-CONFIG/1.2.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/BUILD-CACHE-CONFIG/1.2.0 https://maven.apache.org/xsd/build-cache-config-1.2.0.xsd">
<input>
<global>
<includes>
<!-- By default, project sources and resources directories are included (src/main/java and src/main/resources) -->
<!-- Here, the goal is to include a wider range of src directories (like src/main/assembly or src/main/antora) -->
<include>src/</include>
</includes>
</global>
</input>
<executionControl>
<reconcile>
<plugins>
<plugin artifactId="maven-surefire-plugin" goal="test">
<reconciles>
<reconcile propertyName="skip" skipValue="true"/>
<reconcile propertyName="skipExec" skipValue="true"/>
<reconcile propertyName="skipTests" skipValue="true"/>
<reconcile propertyName="testFailureIgnore" skipValue="true"/>
Copy link
Member

@markpollack markpollack Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mr. claude said this could be dangerous.

When testFailureIgnore=true:

Surefire still executes every test
Test reports are written to target/surefire-reports/
Code coverage data is generated
Any test-triggered side effects happen

The only difference is that a failing test won't fail the build.

The dangerous scenario
Imagine this sequence:

First build: testFailureIgnore=false, tests run, results cached
Second build: testFailureIgnore=true, cache says "this is a skip flag, reuse cached result"
Result: Tests never actually ran on the second build, but Maven thinks they did

You'd get stale test reports, potentially miss new test failures entirely, and have no idea tests were skipped.

</reconciles>
</plugin>
<plugin artifactId="maven-failsafe-plugin" goal="integration-test">
<reconciles>
<reconcile propertyName="skip" skipValue="true"/>
<reconcile propertyName="skipExec" skipValue="true"/>
<reconcile propertyName="skipITs" skipValue="true"/>
<reconcile propertyName="skipTests" skipValue="true"/>
</reconciles>
</plugin>

</plugins>
</reconcile>
</executionControl>
</cache>
2 changes: 1 addition & 1 deletion .mvn/wrapper/maven-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.6/apache-maven-3.8.6-bin.zip
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.1/apache-maven-3.9.1-bin.zip
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
Copy link
Member

@markpollack markpollack Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we update to https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/ @ericbottard ?

Copy link
Member Author

@ericbottard ericbottard Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? Should we also update the wrapper version?
Doesn't matter for build-cache, but why not.

The maven version was updated by the PR you just merged anyway

Copy link
Member

@markpollack markpollack Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, update the wrapper version.