Refactor: Switch from singular utils.py with all fuctions to class based approach #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splunkcloud modules with class based interfaces
bdebek-splunk
added
documentation
Closed
edro15
reviewed
Jan 16, 2025
Collaborator
edro15
left a comment
edro15
left a comment
There was a problem hiding this comment.
Hey @bdebek-splunk ,
Thank you for your efforts on this!!
I did not have the time to review all the changes, but please check these first and eventually solve them before I have a look at the rest. Please reach out in case of questions.. :)
…eport_generator.py with DeploymentReportGenerator class and added DeploymentParser class in apps_processing.py
edro15
reviewed
Jan 21, 2025
Collaborator
edro15
left a comment
edro15
left a comment
There was a problem hiding this comment.
@bdebek-splunk I pushed some changes as well, please review and test as well before merging. Thanks 🙏
…ervice to make execution faster
…ript. fix: fixed variable naming from app to splunkbase_app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 modules:
s3_aws.pyapp_processing.pysplunkcloud.pyAdded changes to repo architecture in README