Skip to content

fix: standardize app naming and update deployment path source #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdebek-splunk merged 2 commits into from
Jan 14, 2025
Merged

fix: standardize app naming and update deployment path source #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3debbeb
fix: standardize app naming and update deployment path source
bdebek-splunk Jan 14, 2025
fe9781d
refactor: comment out dotenv loading for local testing
bdebek-splunk Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/Splunk_TA_app1/default/app.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ version = 1.0.8

[ui]
is_visible = 0
label = app1
label = App1
docs_section_override = AddOns:released

[package]
id = Splunk_TA_app1
id = Splunk_TA_App1

[triggers]
reload.addon_builder = simple
Expand Down
7 changes: 4 additions & 3 deletions deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
from utils import *

# FOR LOCAL TESTING
from dotenv import load_dotenv
load_dotenv(dotenv_path="local.env")
# from dotenv import load_dotenv
# load_dotenv(dotenv_path="local.env")

def main():
if len(sys.argv) != 2:
Expand Down Expand Up @@ -45,7 +45,8 @@ def main():

### 2. Upload_local_configuration ###
# Check if the configuration exists for the app
path = check_all_letter_cases(sys.argv[1], app)
path = os.path.join("environments", sys.argv[1], app)
print(path)
if path:
unpack_merge_conf_and_meta_repack(app, path)
else:
Expand Down
2 changes: 1 addition & 1 deletion environments/uat/es/deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
target:
url: https://staging.admin.splunk.com/scv-shw-217bd09bcbf264/adminconfig/v2/apps/victoria
apps:
Splunk_TA_app1:
Splunk_TA_App1:
s3-bucket: splunk-apps-deployment
source: apps/Splunk_TA_app1.tgz
config:
Expand Down
Loading