Used private var for retry attempts

Author: chillaq

splitio/sync/manager.py

@@ -15,7 +15,7 @@
 class Manager(object):  # pylint:disable=too-many-instance-attributes
     """Manager Class."""
 
-    SYNC_ALL_ATTEMPTS = -1
+    _SYNC_ALL_ATTEMPTS = -1
     _CENTINEL_EVENT = object()
 
     def __init__(self, ready_flag, synchronizer, auth_api, streaming_enabled, sdk_metadata, sse_url=None, client_key=None):  # pylint:disable=too-many-arguments
@@ -67,7 +67,7 @@ def start(self):
         :type max_retry_attempts: int
         """
         try:
-            self._synchronizer.sync_all(self.SYNC_ALL_ATTEMPTS)
+            self._synchronizer.sync_all(self._SYNC_ALL_ATTEMPTS)
             self._ready_flag.set()
             self._synchronizer.start_periodic_data_recording()
             if self._streaming_enabled:

splitio/sync/synchronizer.py

@@ -304,7 +304,7 @@ def sync_all(self, max_retry_attempts=-1):
             try:
                 if not self.synchronize_splits(None, False):
                     retry_attempts = self._retry_block(max_retry_attempts, retry_attempts)
-                    if not max_retry_attempts == -1 and retry_attempts == -1:
+                    if max_retry_attempts != -1 and retry_attempts == -1:
                         break
                     continue
 
@@ -318,14 +318,14 @@ def sync_all(self, max_retry_attempts=-1):
                 _LOGGER.error("Exception caught when trying to sync all data: %s", str(exc))
                 _LOGGER.debug('Error: ', exc_info=True)
                 retry_attempts = self._retry_block(max_retry_attempts, retry_attempts)
-                if not max_retry_attempts == -1 and retry_attempts == -1:
+                if max_retry_attempts != -1 and retry_attempts == -1:
                     break
                 continue
 
         _LOGGER.error("Could not correctly synchronize splits and segments after %d attempts.", retry_attempts)
 
     def _retry_block(self, max_retry_attempts, retry_attempts):
-        if not max_retry_attempts == -1:
+        if max_retry_attempts != -1:
             retry_attempts += 1
             if retry_attempts > max_retry_attempts:
                 return -1

tests/sync/test_manager.py

@@ -45,7 +45,7 @@ def run(x):
         synchronizer = Synchronizer(synchronizers, split_tasks)
         manager = Manager(threading.Event(), synchronizer,  mocker.Mock(), False, SdkMetadata('1.0', 'some', '1.2.3.4'))
 
-        manager.SYNC_ALL_ATTEMPTS = 1
+        manager._SYNC_ALL_ATTEMPTS = 1
         manager.start()  # should not throw!
 
     def test_start_streaming_false(self, mocker):