used private variable for manager retry attempts

Author: chillaq

splitio/sync/manager.py

@@ -15,6 +15,7 @@
 class Manager(object):  # pylint:disable=too-many-instance-attributes
     """Manager Class."""
 
+    SYNC_ALL_ATTEMPTS = -1
     _CENTINEL_EVENT = object()
 
     def __init__(self, ready_flag, synchronizer, auth_api, streaming_enabled, sdk_metadata, sse_url=None, client_key=None):  # pylint:disable=too-many-arguments
@@ -58,15 +59,15 @@ def recreate(self):
         """Recreate poolers for forked processes."""
         self._synchronizer._split_synchronizers._segment_sync.recreate()
 
-    def start(self, retry_attempts=-1):
+    def start(self):
         """
         Start the SDK synchronization tasks.
 
         :param max_retry_attempts: apply max attempts if it set to absilute integer.
         :type max_retry_attempts: int
         """
         try:
-            self._synchronizer.sync_all(retry_attempts)
+            self._synchronizer.sync_all(self.SYNC_ALL_ATTEMPTS)
             self._ready_flag.set()
             self._synchronizer.start_periodic_data_recording()
             if self._streaming_enabled:

tests/sync/test_manager.py

@@ -45,7 +45,8 @@ def run(x):
         synchronizer = Synchronizer(synchronizers, split_tasks)
         manager = Manager(threading.Event(), synchronizer,  mocker.Mock(), False, SdkMetadata('1.0', 'some', '1.2.3.4'))
 
-        manager.start(1)  # should not throw!
+        manager.SYNC_ALL_ATTEMPTS = 1
+        manager.start()  # should not throw!
 
     def test_start_streaming_false(self, mocker):
         splits_ready_event = threading.Event()