Skip to content

Commit 5dfc51c

Browse files
committed
use pt instead of seenAt
1 parent 15536c9 commit 5dfc51c

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

client/src/main/java/io/split/client/dtos/KeyImpression.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class KeyImpression {
99
public String label;
1010
public long time;
1111
public Long changeNumber; // can be null if there is no changeNumber
12-
public Long seenAt;
12+
public Long pt;
1313

1414
@Override
1515
public boolean equals(Object o) {

client/src/main/java/io/split/client/impressions/ImpressionsManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ private void sendImpressions() {
132132
impressionsForTest = new ArrayList<>();
133133
tests.put(ki.feature, impressionsForTest);
134134
}
135-
ki.seenAt = _impressionObserver.testAndSet(ki);
135+
ki.pt = _impressionObserver.testAndSet(ki);
136136
impressionsForTest.add(ki);
137137
}
138138

client/src/test/java/io/split/client/impressions/ImpressionsManagerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ public void alreadySeenImpressionsAreMarked() throws URISyntaxException {
177177
List<TestImpressions> captured = impressionsCaptor.getValue();
178178
for (TestImpressions testImpressions : captured) {
179179
for (KeyImpression keyImpression : testImpressions.keyImpressions) {
180-
assertThat(keyImpression.seenAt, is(equalTo(null)));
180+
assertThat(keyImpression.pt, is(equalTo(null)));
181181
}
182182
}
183183

@@ -194,7 +194,7 @@ public void alreadySeenImpressionsAreMarked() throws URISyntaxException {
194194
captured = impressionsCaptor.getValue();
195195
for (TestImpressions testImpressions : captured) {
196196
for (KeyImpression keyImpression : testImpressions.keyImpressions) {
197-
assertThat(keyImpression.seenAt, is(equalTo(keyImpression.time)));
197+
assertThat(keyImpression.pt, is(equalTo(keyImpression.time)));
198198
}
199199
}
200200

client/src/test/java/io/split/engine/splitter/HashConsistencyTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ private void validateFileMurmurHash3_64(File file) throws IOException {
140140
long expected_hash = Long.parseLong(parts[2]);
141141
long[] hash = MurmurHash3.hash128x64(key.getBytes(), 0, key.length(), seed);
142142
Assert.assertEquals(expected_hash, hash[0]);
143-
144143
}
145144
}
146145
}

0 commit comments

Comments
 (0)