add murmur3_64 test suite;

Author: mredolatti

client/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>3.3.3</version>
+        <version>3.3.3-rc1</version>
     </parent>
     <artifactId>java-client</artifactId>
     <packaging>jar</packaging>

client/src/main/java/io/split/client/utils/MurmurHash3.java

@@ -208,7 +208,7 @@ public static long[] hash128x64(final byte[] data) {
      * @param seed The initial seed value
      * @return The 128-bit hash (2 longs)
      */
-    private static long[] hash128x64(final byte[] data, final int offset, final int length, final long seed) {
+    public static long[] hash128x64(final byte[] data, final int offset, final int length, final long seed) {
         long h1 = seed;
         long h2 = seed;
         final int nblocks = length >> 4;

client/src/test/java/io/split/client/impressions/ImpressionObserverTest.java

@@ -1,5 +1,6 @@
 package io.split.client.impressions;
 
+import com.google.common.base.Strings;
 import io.split.client.dtos.KeyImpression;
 // import jdk.nashorn.internal.ir.debug.ObjectSizeCalculator;
 import org.junit.Test;
@@ -58,7 +59,7 @@ public void testBasicFunctionality() {
     }
 
     @Test
-    public void testMemoryUsageStopsWhenCacheIsFull() throws InvocationTargetException, IllegalAccessException {
+    public void testMemoryUsageStopsWhenCacheIsFull() throws Exception {
 
         Class objectSizeCalculatorClass;
         ClassLoader classLoader = this.getClass().getClassLoader();
@@ -67,8 +68,11 @@ public void testMemoryUsageStopsWhenCacheIsFull() throws InvocationTargetExcepti
             objectSizeCalculatorClass = classLoader.loadClass("jdk.nashorn.internal.ir.debug.ObjectSizeCalculator");
             getObjectSize = objectSizeCalculatorClass.getMethod("getObjectSize", Object.class);    //getObjectSize(observer);
         } catch (ClassNotFoundException | NoSuchMethodException e) {
-            _log.error("This test only runs with the hotspot JVM. PLEASE ensure it runs correctly at least locally. " +
-                    "Ignoring test now.");
+            _log.error("This test only runs with the hotspot JVM. It's ignored locally, but mandatory on CI");
+            if (!Strings.isNullOrEmpty(System.getenv("CI"))) { // If the CI environment variable is present
+                throw new Exception("Setup CI to run with a hotspot JVM");
+            }
+            // Otherwise just ignore this test.
             return;
         }
 

client/src/test/java/io/split/engine/splitter/HashConsistencyTest.java

@@ -1,6 +1,7 @@
 package io.split.engine.splitter;
 
 import com.google.common.hash.Hashing;
+import io.split.client.utils.MurmurHash3;
 import org.junit.Assert;
 import org.junit.Ignore;
 import org.junit.Test;
@@ -56,6 +57,13 @@ public void testGuavaMurmur3HashNonAlphaNum() throws IOException {
         validateFileGuavaMurmur3Hash(file);
     }
 
+    @Test
+    public void testMurmurHash3_64() throws IOException {
+        URL resource = getClass().getClassLoader().getResource("murmur3_64_uuids.csv");
+        File file = new File(resource.getFile());
+        validateFileMurmurHash3_64(file);
+    }
+
     private void validateFileLegacyHash(File file) throws IOException {
         BufferedReader reader = new BufferedReader(new FileReader(file));
         reader.readLine(); // Header
@@ -111,10 +119,28 @@ private void validateFileGuavaMurmur3Hash(File file) throws IOException {
             int expected_bucket = Integer.parseInt(parts[3]);
 
             int hash = Hashing.murmur3_32(seed).hashString(key, Charset.forName("UTF-8")).asInt();
+
             int bucket = Splitter.bucket(hash);
 
             Assert.assertEquals(expected_hash, hash);
             Assert.assertEquals(expected_bucket, bucket);
         }
     }
+
+    private void validateFileMurmurHash3_64(File file) throws IOException {
+        BufferedReader reader = new BufferedReader(new FileReader(file));
+        reader.readLine(); // Header
+
+        String line;
+        int i = 0;
+        while ((line = reader.readLine()) != null) {
+            String[] parts = line.split(",");
+            String key = parts[0];
+            long seed = Long.parseLong(parts[1]);
+            long expected_hash = Long.parseLong(parts[2]);
+            long[] hash = MurmurHash3.hash128x64(key.getBytes(), 0, key.length(), seed);
+            Assert.assertEquals(expected_hash, hash[0]);
+
+        }
+    }
 }