Skip to content

Disco week #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanzmauro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disco week #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/services/splitio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ splitService.factory('splitio', function() {
},
// In non-localhost mode, this map is ignored.
features: {
feature_1: 'off',
feature_2: 'on',
feature_3: 'v2'
feature_flag_1: 'off',
feature_flag_2: 'on',
feature_flag_3: 'v2'
}
});

Expand Down
6 changes: 3 additions & 3 deletions app/view1/view1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ angular.module('myApp.view1', ['ngRoute', 'splitModule'])
}])

.controller('View1Ctrl', ['$scope', 'splitio', function($scope, splitio) {
$scope.feature_1 = splitio.getTreatment('feature_1');
$scope.feature_2 = splitio.getTreatment('feature_2');
$scope.feature_3 = splitio.getTreatment('feature_3');
$scope.feature_flag_1 = splitio.getTreatment('feature_flag_1');
$scope.feature_flag_2 = splitio.getTreatment('feature_flag_2');
$scope.feature_flag_3 = splitio.getTreatment('feature_flag_3');
}]);
6 changes: 3 additions & 3 deletions app/view1/view1_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ describe('myApp.view1 module', function() {
it('Scneario where splitio sdk use off-the-grid mode', inject(function($controller) {
var $scope = {};
var view1Ctrl = $controller('View1Ctrl', { $scope });
expect($scope.feature_1).toEqual('off');
expect($scope.feature_2).toEqual('on');
expect($scope.feature_3).toEqual('v2');
expect($scope.feature_flag_1).toEqual('off');
expect($scope.feature_flag_2).toEqual('on');
expect($scope.feature_flag_3).toEqual('v2');
}));
});

Expand Down
6 changes: 3 additions & 3 deletions app/view2/view2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ angular.module('myApp.view2', ['ngRoute', 'splitModule'])
}])

.controller('View2Ctrl', ['$scope', 'splitio', function($scope, splitio) {
$scope.feature_1 = splitio.getTreatment('feature_1');
$scope.feature_2 = splitio.getTreatment('feature_2');
$scope.feature_3 = splitio.getTreatment('feature_3');
$scope.feature_flag_1 = splitio.getTreatment('feature_flag_1');
$scope.feature_flag_2 = splitio.getTreatment('feature_flag_2');
$scope.feature_flag_3 = splitio.getTreatment('feature_flag_3');
}]);
6 changes: 3 additions & 3 deletions app/view2/view2_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ describe('View 2 Module', function() {
var $scope = {};
// $controller calls getTreatment internally
var view1Ctrl = $controller('View2Ctrl', { $scope });
expect($scope.feature_1).toEqual('off');
expect($scope.feature_2).toEqual('off');
expect($scope.feature_3).toEqual('off');
expect($scope.feature_flag_1).toEqual('off');
expect($scope.feature_flag_2).toEqual('off');
expect($scope.feature_flag_3).toEqual('off');
}));

});
Expand Down