Skip to content

[PoC] system bar button item #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Draft

[PoC] system bar button item #3403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ios/RNSBarButtonItem.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,28 @@ - (instancetype)initWithConfig:(NSDictionary<NSString *, id> *)dict
menuAction:(RNSBarButtonMenuItemAction)menuAction
imageLoader:(RCTImageLoader *)imageLoader
{
// When title is equal to "search", then use the system search item
// TODO: in actual implementation add a field to config to specify system item type
// https://developer.apple.com/documentation/uikit/uibarbuttonitem/systemitem?language=objc
NSString *title = dict[@"title"];
if (title != nil && [title isEqualToString:@"search"]) {
self = [super initWithBarButtonSystemItem:UIBarButtonSystemItemSearch target:nil action:nil];
if (self) {
NSString *buttonId = dict[@"buttonId"];
if (buttonId && action) {
self.target = self;
self.action = @selector(handleBarButtonItemPress:);
_itemAction = action;
_buttonId = buttonId;
}
}
return self;
}
self = [super init];
if (!self) {
return self;
}

NSString *title = dict[@"title"];
NSDictionary *imageSourceObj = dict[@"imageSource"];
NSDictionary *templateSourceObj = dict[@"templateSource"];
NSString *sfSymbolName = dict[@"sfSymbolName"];
Expand Down