Skip to content

feat(Android, Tabs): handle preventing tab change on Android #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(Android, Tabs): handle preventing tab change on Android #3350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e54046a
don't change menu item on user tap
kligarski Oct 28, 2025
4552703
move selected item id update back
kligarski Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion android/src/main/java/com/swmansion/rnscreens/gamma/tabs/TabsHost.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ class TabsHost(

private var interfaceInsetsChangeListener: SafeAreaView? = null

// We need to differentiate between user tapping the menu item
// and update requested from JS.
private var menuItemSelectedViaContainerUpdate = false
Copy link
Contributor

@kmichalikk kmichalikk Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something, or is this supposed to not be triggered when controlledBottomTabs=false, but it is? Also IMO the name is a bit unclear.

Copy link
Contributor Author

@kligarski kligarski Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Android, only controlled bottom tabs are currently supported.

I did use viaContainerUpdate name because I guess that there is a possibility to call container update from native code, not only as a result of JS focused tab change. I can maybe reverse the logic and use menuItemSelectedByUser or something like this but I'm not sure.


private val appearanceCoordinator =
TabsHostAppearanceCoordinator(wrappedContext, bottomNavigationView, tabScreenFragments)

Expand Down Expand Up @@ -221,7 +225,12 @@ class TabsHost(
val fragment = getFragmentForMenuItemId(item.itemId)
val tabKey = fragment?.tabScreen?.tabKey ?: "undefined"
eventEmitter.emitOnNativeFocusChange(tabKey)
true
if (menuItemSelectedViaContainerUpdate) {
menuItemSelectedViaContainerUpdate = false
true
} else {
false
}
}
}

Expand Down Expand Up @@ -317,6 +326,7 @@ class TabsHost(

appearanceCoordinator.updateTabAppearance(this)

menuItemSelectedViaContainerUpdate = true
Copy link
Contributor

@kmichalikk kmichalikk Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it in updateSelectedTab instead of updateBottomNavigationViewAppearance? It would be a bit more logical there, or these 2 are not always called together ?

Copy link
Contributor Author

@kligarski kligarski Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it as well but I think on Android managing BottomNavigationView and shown screens/fragments is separated and those methods reflect that. Maybe we should think about renaming those methods though.

bottomNavigationView.selectedItemId =
checkNotNull(getSelectedTabScreenFragmentId()) { "[RNScreens] A single selected tab must be present" }

Expand Down
Loading