feat: add support for inline image on iOS #271
+313
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exploIF
reviewed
Nov 21, 2025
| } | ||
| } | ||
|
|
||
| - (void)addImage:(NSString *)uri |
Collaborator
There was a problem hiding this comment.
One general note, I think we should add support for setting image width and height directly when applying image style. That way we can specify dimensions for each image separately, which will be very useful as images may have different aspect ratios.
This should be done for both Android and iOS, but we can definitely handle that in separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #170
Add support for inline image
Test Plan
Run Example app and play with inline image
Screenshots / Videos
Nagranie.z.ekranu.2025-11-21.o.10.05.25.mov
Compatibility