Feat/foreground service notifications #802

poneciak57 · 2025-11-11T19:23:47Z

💀
Closes #820
Closes RNAA-310

TODO

Android notification FS rewrite (@poneciak57)
Android recorder notification (@poneciak57)
Change recorder notification on android to not use media session (@poneciak57)
IOS notification rewrite (@poneciak57)
Docs update (@miloszwielgus)
web mocks update (@miloszwielgus)

Maybe TODO

~~NotificationReceiver for notification dissmised event can be centralized right now there are two receivers~~ (not wanted)

⚠️ Breaking changes ⚠️

changed api for playback notification management
insted of using AudioManager you should use PlaybackNotificationManager

Introduced changes

new RecordingNotificationManager for management of notification dedicated for recording
new PlaybackNotificationManager for management of notification dedicated for playback
deleted methods for lockscreen info in AudioManager

Checklist

packages/audiodocs/docs/system/audio-manager.mdx

…re-mansion/react-native-audio-api into feat/fs_android_recording

michalsek

Small nitpicks, but overall great job, thanks for this! :)

packages/audiodocs/docs/system/playback-notification-manager.mdx

packages/audiodocs/docs/system/recording-notification-manager.mdx

...-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/MediaSessionManager.kt

...id/src/main/java/com/swmansion/audioapi/system/notification/ForegroundNotificationService.kt

...pi/android/src/main/java/com/swmansion/audioapi/system/notification/RecordingNotification.kt

packages/react-native-audio-api/src/web-system/notification/RecordingNotificationManager.ts

packages/audiodocs/docs/system/playback-notification-manager.mdx

maciejmakowski2003

beside a few nitpicks, really great work!!! fingers crossed that it works as well as android code looks 🙃

maciejmakowski2003 · 2025-11-25T14:31:15Z

apps/common-app/src/examples/PlaybackNotification/PlaybackNotification.tsx

+  useEffect(() => {
+    // Create AudioContext in suspended state
+    // Will be resumed when showing notification
+    audioContextRef.current = new AudioContext({ initSuspended: true });


we do not have that option anymore

AudioContext is by default suspended. However if for the first time user starts sth, it will resume context.

maciejmakowski2003 · 2025-11-25T15:23:49Z

packages/react-native-audio-api/src/system/notification/types.ts

+  | 'skipBackward';
+
+/// Event names for playback notification actions.
+interface PlaybackNotificationEvent {


where is seek event? (change playback position)

maciejmakowski2003 · 2025-11-25T15:24:28Z

packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm

+  }
+
+  // Disable all remote commands
+  MPRemoteCommandCenter *remoteCenter = [MPRemoteCommandCenter sharedCommandCenter];


do we need all of them? we only support some subset

mdydek · 2025-11-25T11:37:37Z

packages/react-native-audio-api/src/specs/NativeAudioAPIModule.ts

+  registerNotification(
+    type: string,
+    key: string
+  ): Promise<{ success: boolean; error?: string }>;
+  showNotification(
+    key: string,
+    options: { [key: string]: string | boolean | number | undefined }
+  ): Promise<{ success: boolean; error?: string }>;
+  updateNotification(
+    key: string,
+    options: { [key: string]: string | boolean | number | undefined }
+  ): Promise<{ success: boolean; error?: string }>;
+  hideNotification(key: string): Promise<{ success: boolean; error?: string }>;
+  unregisterNotification(
+    key: string
+  ): Promise<{ success: boolean; error?: string }>;


you can extract repeating types to some named interfaces and types

mdydek · 2025-11-25T12:00:06Z

packages/react-native-audio-api/ios/audioapi/ios/system/notification/NotificationRegistry.mm

+{
+  if (!type || !key) {
+    NSLog(@"[NotificationRegistry] Invalid type or key");
+    return NO;


we need to agree internally on consistency in objective-c parts
bool vs BOOL
true vs YES
false vs NO
anyway it will require some changes

mdydek · 2025-11-25T12:13:11Z

packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm

+  if ([control isEqualToString:@"play"]) {
+    remoteCommandName = @"play";
+  } else if ([control isEqualToString:@"pause"]) {
+    remoteCommandName = @"pause";
+  } else if ([control isEqualToString:@"next"]) {
+    remoteCommandName = @"next";
+  } else if ([control isEqualToString:@"previous"]) {
+    remoteCommandName = @"previous";
+  } else if ([control isEqualToString:@"skipForward"]) {
+    remoteCommandName = @"skipForward";
+  } else if ([control isEqualToString:@"skipBackward"]) {
+    remoteCommandName = @"skipBackward";
+  } else if ([control isEqualToString:@"seek"]) {
+    remoteCommandName = @"seek";
+  }


Suggested change

if ([control isEqualToString:@"play"]) {

remoteCommandName = @"play";

} else if ([control isEqualToString:@"pause"]) {

remoteCommandName = @"pause";

} else if ([control isEqualToString:@"next"]) {

remoteCommandName = @"next";

} else if ([control isEqualToString:@"previous"]) {

remoteCommandName = @"previous";

} else if ([control isEqualToString:@"skipForward"]) {

remoteCommandName = @"skipForward";

} else if ([control isEqualToString:@"skipBackward"]) {

remoteCommandName = @"skipBackward";

} else if ([control isEqualToString:@"seek"]) {

remoteCommandName = @"seek";

}

NSSet *validControls = [NSSet setWithObjects:

@"play",

@"pause",

@"next",

@"previous",

@"skipForward",

@"skipBackward",

@"seek"

];

if ([validControls containsObject:control]) {

[self enableRemoteCommand:control enabled:enabled];

}

mdydek · 2025-11-25T12:26:20Z

packages/react-native-audio-api/src/specs/NativeAudioAPIModule.ts

+
+  // New notification system
+  registerNotification(
+    type: string,


you can type it stronger than string

mdydek · 2025-11-25T12:30:16Z

packages/react-native-audio-api/src/system/notification/RecordingNotificationManager.ts

+      'recording',
+      this.notificationKey


idk if its just me, bur registering notification of type 'recording' for 'recording' key seems kind of "strange"

if it is intended as only one notification at the time, I think it can be simplified, but if it can display more than one there is no method to change the notificationKey

mdydek · 2025-11-25T16:19:45Z

...ct-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/LockScreenManager.kt

why only android lock screen manager is deleted, if ios one is not used either?

mdydek · 2025-11-25T16:20:43Z

packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm

+#define NOW_PLAYING_INFO_KEYS \
+  @{ \
+    @"title" : MPMediaItemPropertyTitle, \
+    @"artist" : MPMediaItemPropertyArtist, \
+    @"album" : MPMediaItemPropertyAlbumTitle, \
+    @"duration" : MPMediaItemPropertyPlaybackDuration, \
+    @"elapsedTime" : MPNowPlayingInfoPropertyElapsedPlaybackTime, \
+    @"speed" : MPNowPlayingInfoPropertyPlaybackRate \
+  }


what about artwork?

mdydek · 2025-11-25T16:24:57Z

packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm

+    } else if ([state isEqualToString:@"paused"]) {
+      playbackState = MPNowPlayingPlaybackStatePaused;
+    } else if ([state isEqualToString:@"stopped"]) {
+      playbackState = MPNowPlayingPlaybackStateStopped;


you cannot pass 'stopped' from typescript

mdydek · 2025-11-25T16:26:24Z

packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm

+  self.playingInfoCenter.playbackState = playbackState;
+
+  // Handle artwork
+  NSString *artworkUrl = [self getArtworkUrl:_currentInfo[@"artwork"]];


artworkUrl will always be null, because there is no entry in map defined above and you put in current info only keys that exist in pre-defined map

mdydek · 2025-11-25T16:55:07Z

packages/react-native-audio-api/ios/audioapi/ios/AudioAPIModule.mm

+    registerNotification : (NSString *)type key : (NSString *)key resolve : (RCTPromiseResolveBlock)
+        resolve reject : (RCTPromiseRejectBlock)reject)


if the method is based on promises and cannot be resolved instantly, invoke methods on seperate queue, similar to getDevicesInfo function

poneciak57 added 6 commits November 10, 2025 11:51

feat: new android notification system

f4af099

feat: playback notification in new system

3cbbb8e

chore: formatting

11249a7

fix: fixed some issues and dropped old FS

30c524f

chore: minor touches

5563fdf

feat: types update

ea93261

poneciak57 self-assigned this Nov 13, 2025

poneciak57 added feature New feature refactoring improvement labels Nov 13, 2025

feat: docs draft

59c02e6

poneciak57 commented Nov 13, 2025

View reviewed changes

packages/audiodocs/docs/system/audio-manager.mdx Outdated Show resolved Hide resolved

miloszwielgus and others added 11 commits November 13, 2025 13:32

fix: minor doc imrovements

12db627

feat: recording notification

8b8a402

Merge branch 'feat/fs_android_recording' of https://github.com/softwa…

260d781

…re-mansion/react-native-audio-api into feat/fs_android_recording

chore: formatting

0812d1c

feat: recording notification manager docs

61624a5

feat: mock web methods

1300350

feat: ios omfg why is it so bad

af1ebd7

chore: formatting

6ac246a

feat: changed recording notification to be simpler

e218cc8

feat: added more options to recording notification

d5c87e4

chore: formatting

3a3b9f5

poneciak57 marked this pull request as ready for review November 20, 2025 14:39

poneciak57 added 2 commits November 20, 2025 15:46

Merge branch 'main' into feat/fs_android_recording

dbe4abb

chore: formatting

b432ff7

poneciak57 requested review from maciejmakowski2003, mdydek and michalsek November 20, 2025 14:51

chore: bump ktlint to 1.7

313eaa6

michalsek approved these changes Nov 21, 2025

View reviewed changes

poneciak57 and others added 7 commits November 24, 2025 20:43

chore: docs updt

42e6259

docs: added examples to documentation

a980113

feat: made foreground service more centralized

4b9c13e

feat: made foreground service more centralized

35a19b6

chore: neatpicks

e02c3d1

docs: better color for dark theme

5a5dcc3

feat: removed unused android imports

ff4f914

maciejmakowski2003 requested changes Nov 25, 2025

View reviewed changes

michalsek self-requested a review November 25, 2025 15:42

mdydek requested changes Nov 25, 2025

View reviewed changes

		registerNotification : (NSString )type key : (NSString )key resolve : (RCTPromiseResolveBlock)
		resolve reject : (RCTPromiseRejectBlock)reject)

Uh oh!

Feat/foreground service notifications #802

Are you sure you want to change the base?

Feat/foreground service notifications #802

Conversation

poneciak57 commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Maybe TODO

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

Uh oh!

Uh oh!

michalsek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maciejmakowski2003 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

poneciak57 commented Nov 11, 2025 •

edited

Loading