Skip to content

Please consider the following formatting changes to #13623 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #13623 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGCF/Femto3D/Tasks/femto3dQA.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -45,14 +45,14 @@
/// Construct a registry object with direct declaration
HistogramRegistry registry{"registry", {}, OutputObjHandlingPolicy::AnalysisObject};

Configurable<bool> _isMC{"isMC", false, ""};

Check failure on line 48 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)

Configurable<bool> _removeSameBunchPileup{"removeSameBunchPileup", false, ""};

Check failure on line 50 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<bool> _requestGoodZvtxFT0vsPV{"requestGoodZvtxFT0vsPV", false, ""};

Check failure on line 51 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<bool> _requestVertexITSTPC{"requestVertexITSTPC", false, ""};

Check failure on line 52 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<int> _requestVertexTOForTRDmatched{"requestVertexTOFmatched", 0, "0 -> no selectio; 1 -> vertex is matched to TOF or TRD; 2 -> matched to both;"};

Check failure on line 53 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<bool> _requestNoCollInTimeRangeStandard{"requestNoCollInTimeRangeStandard", false, ""};

Check failure on line 54 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<bool> _requestIsGoodITSLayersAll{"requestIsGoodITSLayersAll", false, "cut time intervals with dead ITS staves"};

Check failure on line 55 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<std::pair<float, float>> _IRcut{"IRcut", std::pair<float, float>{0.f, 100.f}, "[min., max.] IR range to keep events within"};
Configurable<std::pair<int, int>> _OccupancyCut{"OccupancyCut", std::pair<int, int>{0, 10000}, "[min., max.] occupancy range to keep events within"};

Expand Down Expand Up @@ -111,7 +111,7 @@
TOFcuts = std::make_pair(_particlePDG, _tofNSigma);

int N = _dcaBinning.value[0]; // number of bins -- must be odd otherwise will be increased by 1
if (N % 2 != 1) {

Check failure on line 114 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
N += 1;
}

Expand Down Expand Up @@ -170,7 +170,7 @@
template <bool FillExtra, typename ColsType, typename TracksType>
void fillHistograms(ColsType const& collisions, TracksType const& tracks)
{
for (auto& collision : collisions) {

Check failure on line 173 in PWGCF/Femto3D/Tasks/femto3dQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (_removeSameBunchPileup && !collision.isNoSameBunchPileup())
continue;
if (_requestGoodZvtxFT0vsPV && !collision.isGoodZvtxFT0vsPV())
Expand All @@ -197,7 +197,7 @@
}

for (const auto& track : tracks) {
if (track.sign()!=_sign)
if (track.sign() != _sign)
continue;
if (_removeSameBunchPileup && !track.template singleCollSel_as<ColsType>().isNoSameBunchPileup())
continue;
Expand Down
Loading