Skip to content

change tags #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

change tags #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
matrix:
include:
- series: innovation
version: 9.3
version: 9
extra_tag: Innovation
- series: lts
version: 8.4
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Both images are based on Debian 12 (slim) for minimal image size.
### Innovation Series (9.5.x) [(Dockerfile)](docker/innovation/Dockerfile)
```bash
cd docker/innovation
docker build -t snickerjp/docker-mysql-shell:9.5 .
docker build -t snickerjp/docker-mysql-shell:9 .
Copy link

@gemini-code-assist gemini-code-assist bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've updated the tag to 9 in this command, the rest of the README.md file is now inconsistent. For example, the heading on line 24 still says Innovation Series (9.5.x), and the 'Available Tags' section on line 14 still lists the tag as snickerjp/docker-mysql-shell:9.5.

To avoid confusion for users, please update all references to 9.5 and 9.5.x to be consistent with the new 9 tag. For example, you might want to change 9.5.x to 9.x and update the tag list.

```

### LTS Series (8.4.x) [(Dockerfile)](docker/lts/Dockerfile)
Expand All @@ -39,7 +39,7 @@ Run MySQL Shell container:

```bash
# Innovation Series
docker run -it snickerjp/docker-mysql-shell:9.5
docker run -it snickerjp/docker-mysql-shell:9
# or
docker run -it snickerjp/docker-mysql-shell:Innovation

Expand All @@ -54,7 +54,7 @@ docker run -it snickerjp/docker-mysql-shell:latest
To connect to a MySQL Server:
```bash
# Innovation Series
docker run -it snickerjp/docker-mysql-shell:9.5 --uri mysql://user:pass@host:port/schema
docker run -it snickerjp/docker-mysql-shell:9 --uri mysql://user:pass@host:port/schema
# or using Innovation tag
docker run -it snickerjp/docker-mysql-shell:Innovation --uri mysql://user:pass@host:port/schema

Expand Down