M1fixes #49
Open
M1fixes #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2024 10:46
"zsh: illegal hardware instruction python" could be worked around using direct imports in another case
- only load polar if requested explicitly - not needed for main function see: pola-rs/polars#11650 (polars on M1 needs correct compiled binaries)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched to direct imports, but this could be reverted...
Do not import polars:
An issue for M1 Macs is polars, which needs to use the arm instructions. Apparently M1 Macs can use two versions of instructions, but I did not explore the details. Anyways
In mrmr-selection the line
leads to
zsh: illegal hardware instruction.Therefore I suggest to only import polars if the functionality is requested.
install from GitHub
Allow installation using:
by moving version to metadata (
setup.py) and importing the version in the package dynamically.