Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion framework/components/simple_node_set/reload.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ import (
// UpgradeNodeSet updates nodes configuration TOML files
// this API is discouraged, however, you can use it if nodes require restart or configuration updates, temporarily!
func UpgradeNodeSet(t *testing.T, in *Input, bc *blockchain.Output, wait time.Duration) (*Output, error) {
uniq := fmt.Sprintf("%s-%s-%s", framework.DefaultCTFLogsDir, t.Name(), uuid.NewString()[0:4])
return UpgradeNodeSetWithTag(t.Name(), in, bc, wait)
}

Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new UpgradeNodeSetWithTag function lacks documentation. Add a comment explaining its purpose, parameters, and how it differs from UpgradeNodeSet, similar to the existing documentation on line 15-16.

Suggested change
// UpgradeNodeSetWithTag performs the same node set upgrade as UpgradeNodeSet but allows
// the caller to provide an explicit tag used when saving container logs. The tag is
// incorporated into the log directory name instead of relying on t.Name(), which can be
// useful when running outside of testing.T or when finer-grained tagging is desired.

Copilot uses AI. Check for mistakes.
func UpgradeNodeSetWithTag(tag string, in *Input, bc *blockchain.Output, wait time.Duration) (*Output, error) {
uniq := fmt.Sprintf("%s-%s-%s", framework.DefaultCTFLogsDir, tag, uuid.NewString()[0:4])
if _, err := framework.SaveContainerLogs(uniq); err != nil {
return nil, err
}
Expand Down
Loading