3.7.8 Add json_for_script function to remove unicode data and escape HTML and XML #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cruz-evan Looks like there's a test that needs fixing (quotes are now reversed): FAIL: test_get_filtered (tests.test_templatetags.GetFileExtensionsTemplateTagTests)Traceback (most recent call last): |
cruz-evan
force-pushed
the
json_for_script_function
branch
from
44a8be0 to
0a10cb9
Compare
DylanYoung
reviewed
Jun 11, 2019
…HTML and XML -Similar implementation to Django 2.1 function json_script -Fixes the problem where the upload button would not appear if the list had unicode data inside
cruz-evan
force-pushed
the
json_for_script_function
branch
from
0a10cb9 to
2aa42f4
Compare
DylanYoung
reviewed
Jun 17, 2019
| '.tif', '.tiff', '.mp3', '.mp4', '.wav', '.aiff', '.midi', '.m4p', '.m4v', '.webm' | ||
| ])) | ||
|
|
||
| def test_get_filtered(self): |
There was a problem hiding this comment.
@cruz-evan If you unify this with the way the above test is written (as in our fork), then you don't need to worry about these small formatting differences. Probably it should use json.loads instead of eval, since this is the context wherein we hit the issue that necessitated this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error where navigating to the upload page results in a javascript "unexpected string error" error and causing the upload button to not appear on the page. Since mark_safe causes all of the values in the extentions to become unicode this error happens.
Original django-filebrowser 3.7.x does not have mark-safe on the get_file_extentions function.
https://github.com/sehmaschine/django-filebrowser/blob/stable/3.7.x/filebrowser/templatetags/fb_tags.py
-Similar implementation to Django 2.1 function json_script
-Fixes the problem where the upload button would not appear if the list had unicode data inside