Skip to content

WIP: types v3 message attachment breaking changes #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
filmaj wants to merge 2 commits into
base: types-v3
Choose a base branch
from
Draft

WIP: types v3 message attachment breaking changes #1911

filmaj wants to merge 2 commits into from

Conversation

@filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 30, 2024 •
edited
Loading

fixes #1816

  • Use of discriminated unions
  • type tests fully describing constraints

@filmaj filmaj added semver:major enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` labels Aug 30, 2024
@filmaj filmaj added this to the types@3.0.0 milestone Aug 30, 2024
@filmaj filmaj self-assigned this Aug 30, 2024
@filmaj filmaj changed the base branch from main to types-v3 August 30, 2024 21:32
@codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (a2ba1c1) to head (1d4796c).

Additional details and impacted files 
@@            Coverage Diff            @@
##           types-v3    #1911   +/-   ##
=========================================
  Coverage     90.26%   90.26%           
=========================================
  Files            34       34           
  Lines          7666     7666           
  Branches        381      381           
=========================================
  Hits           6920     6920           
  Misses          734      734           
  Partials         12       12
Flag Coverage Δ
cli-hooks 94.94% <ø> (ø)
cli-test 96.93% <ø> (ø)
oauth 76.53% <ø> (ø)
socket-mode 59.59% <ø> (ø)
web-api 96.57% <ø> (ø)
webhook 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj force-pushed the types-v3-du-msg-attachments branch from 7bdb40f to 1d4796c Compare September 3, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@filmaj filmaj

Labels

area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:major

Projects

None yet

Milestone

types@3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@filmaj