Feature/config optimization refactor #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the logic of config builders to config_builders/
Move out benchmark helper, search manager and experiment parameters
apd10
requested review from
Pd172944,
kumarkrishna,
luis-gasparschroeder and
sahiljoshi515
kumarkrishna
requested changes
Dec 8, 2025
Collaborator
kumarkrishna
left a comment
kumarkrishna
left a comment
There was a problem hiding this comment.
in general, this looks good to me. key request:
- for consistency, let's use ALG_top_k .
Collaborator
There was a problem hiding this comment.
can we rename this to vattention_oracle_top_k for consistency
Collaborator
There was a problem hiding this comment.
let's rename to quest_topk
Collaborator
There was a problem hiding this comment.
please rename PQCache -> PQCache_topk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp of config optimization with a single place to configure all config optimizations. Consult the readme in raytune/ for more details