Skip to content

Handle blank addresses in CC and BCC lists, as these cause a Sendgrid error #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle blank addresses in CC and BCC lists, as these cause a Sendgrid error #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d149473
Handle blank addresses in CC and BCC, and add a check to the test.
psyonara Mar 26, 2025
6769a5c
Remove blank check from TO, since this should raise an exception from…
psyonara Mar 26, 2025
c0e47ab
Fix line length being exceeded on previous changes.
psyonara Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sendgrid_backend/mail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,13 @@ def _build_sg_personalization(

if not personalization.ccs:
for addr in msg.cc:
personalization.add_cc(Email(*self._parse_email_address(addr)))
if addr:
Copy link
Owner

@sklarsa sklarsa Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a warning log if addr == ""?

personalization.add_cc(Email(*self._parse_email_address(addr)))

if not personalization.bccs:
for addr in msg.bcc:
personalization.add_bcc(Email(*self._parse_email_address(addr)))
if addr:
Copy link
Owner

@sklarsa sklarsa Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

personalization.add_bcc(Email(*self._parse_email_address(addr)))

if not personalization.custom_args:
for k, v in getattr(msg, "custom_args", {}).items():
Expand Down
6 changes: 4 additions & 2 deletions test/test_mail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ def test_EmailMessage(self):
body="Hello, World!",
from_email="Sam Smith <sam.smith@example.com>",
to=["John Doe <john.doe@example.com>", "jane.doe@example.com"],
cc=["Stephanie Smith <stephanie.smith@example.com>"],
bcc=["Sarah Smith <sarah.smith@example.com>"],
# Include blank address to confirm that it's ignored
cc=["Stephanie Smith <stephanie.smith@example.com>", ""],
# Include blank address to confirm that it's ignored
bcc=["Sarah Smith <sarah.smith@example.com>", ""],
reply_to=["Sam Smith <sam.smith@example.com>"],
)

Expand Down