Skip to content

feat: Introduce SingleStoreChatFactory and SingleStoreEmbeddingsFactory factories that instantiate various flavors of chat and embedding instances. #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 22, 2025
Merged

feat: Introduce SingleStoreChatFactory and SingleStoreEmbeddingsFactory factories that instantiate various flavors of chat and embedding instances. #94

merged 21 commits into from
Sep 22, 2025

Conversation

@mgiannakopoulos
Copy link
Contributor

@mgiannakopoulos mgiannakopoulos commented Sep 17, 2025

No description provided.

@mgiannakopoulos mgiannakopoulos changed the title feat: Introduce SingleStoreChat wrapper that uses interchangeably OpennAI or AmazonBedrockConverse protocol. feat: Introduce SingleStoreChat wrapper that uses interchangeably OpenAI or AmazonBedrockConverse protocol. Sep 17, 2025
kesmit13
kesmit13 reviewed Sep 17, 2025
View reviewed changes
@mgiannakopoulos mgiannakopoulos changed the title feat: Introduce SingleStoreChat wrapper that uses interchangeably OpenAI or AmazonBedrockConverse protocol. feat: Introduce SingleStoreChatFactory factory that instantiates interchangeably OpenAI or AmazonBedrockConverse instances. Sep 19, 2025
@mgiannakopoulos mgiannakopoulos changed the title feat: Introduce SingleStoreChatFactory factory that instantiates interchangeably OpenAI or AmazonBedrockConverse instances. feat: Introduce SingleStoreChatFactory factory that instantiates interchangeably ChatOpenAI or ChatBedrockConverse instances. Sep 19, 2025
@mgiannakopoulos
Hardcode dummy credentials and region info for ChatBedrockConverse cl…
c23f3fa 
…ient.
@mgiannakopoulos
Rename 'region' parameter to 'region_name'.
f2ccfbf
@mgiannakopoulos
Expose 'streaming' parameter setting its oposite value to 'disable_st…
a2728dc 
…reaming' ChatBedrockConverse client.
@mgiannakopoulos
Set the default value for 'streaming' paramter to True.
a0a5197
@mgiannakopoulos
Remove the cache option.
3ea9400
@mgiannakopoulos
Remove unsupported kargs from Bedrock calls.
321fd9b
@mgiannakopoulos
Replace composition wrapper with a factory method.
8ff4dfe
@mgiannakopoulos
Pass bedrock runtime client as client parameter.
f376141
@mgiannakopoulos
Pass also the 'X-BEDROCK-CONVERSE' headers that indicate that the req…
84ad037 
…uets should be handled as passthrough from UMG.
@mgiannakopoulos
Remove some amazon specific headers, along with validation, remove X-…
40de94e 
…BEDROCK headers as well.
@mgiannakopoulos
Remove commented out code; set max retries to 1 for Amazon Bedrock mo…
48b79d7 
…dels.
@mgiannakopoulos
Use 'Union' return type to satisfy pre-commit checks for python versi…
02b1f47 
…on 3.9.
@mgiannakopoulos
Expose also the hostingPlatform for InferenceAPIInfo.
5db3fbf
@mgiannakopoulos
Do not use model prefix, rely on hosting platform.
2fdd49b
@mgiannakopoulos mgiannakopoulos changed the title feat: Introduce SingleStoreChatFactory factory that instantiates interchangeably ChatOpenAI or ChatBedrockConverse instances. feat: Introduce SingleStoreChatFactory and SingleStoreEmbeddingsFactory factories that instantiate various flavors of chat and embedding instances. Sep 22, 2025
kesmit13
kesmit13 reviewed Sep 22, 2025
View reviewed changes
@kesmit13 kesmit13 merged commit 9055445 into main Sep 22, 2025
11 checks passed
@kesmit13 kesmit13 deleted the MCDB-80886 branch September 22, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesmit13 kesmit13 kesmit13 approved these changes

@Prudhvi0717 Prudhvi0717 Prudhvi0717 approved these changes

@hbindu-ss hbindu-ss hbindu-ss approved these changes

@Pancham97 Pancham97 Awaiting requested review from Pancham97

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mgiannakopoulos @kesmit13 @Prudhvi0717 @hbindu-ss