Skip to content

Conversation

@kkampli-singlestore
Copy link
Contributor

This PR adds a check to see if the UDF is async or not in the vector input UDF call.

  1. If the func is async, await to call it directly.
  2. If the func is sync, run it in a separate thread and await the result.

@kkampli-singlestore kkampli-singlestore marked this pull request as draft June 26, 2025 07:51
@kkampli-singlestore kkampli-singlestore force-pushed the users/kaushik/aysnc-support branch from f62de29 to 42313b0 Compare June 27, 2025 13:33
@kesmit13
Copy link
Collaborator

FYI, there is another branch (cancel_udf) that implement async functions already. It also allows for non-async functions to be cancelled if the connection to the database engine is broken.

@kesmit13
Copy link
Collaborator

The PR is #64 . It just needs to be tested a bit more.

@srinathnarayanan
Copy link
Collaborator

The PR is #64 . It just needs to be tested a bit more.

This MR is pretty big for us to test end to end, @kkampli-singlestore can you maybe create a smaller MR with just kevin's Async function changes? thanks!

@kkampli-singlestore kkampli-singlestore force-pushed the users/kaushik/aysnc-support branch 4 times, most recently from c826775 to 8926ef6 Compare July 3, 2025 15:13
@kkampli-singlestore kkampli-singlestore force-pushed the users/kaushik/aysnc-support branch from 8926ef6 to 230033f Compare July 3, 2025 15:19
@kkampli-singlestore kkampli-singlestore marked this pull request as ready for review July 7, 2025 15:36
@kkampli-singlestore kkampli-singlestore marked this pull request as draft July 7, 2025 17:10
@kesmit13
Copy link
Collaborator

Async support has been addded in 9c649cf

@kesmit13 kesmit13 closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants