Skip to content

Conversation

@mgiannakopoulos
Copy link
Contributor

@mgiannakopoulos mgiannakopoulos commented Dec 2, 2025

WIth this change we:

  • Revert the ability for OpenAI clients to dynamically pass api_token and obo_token values (we can achieve this by providing a custom http_client in the factory methods and ensuring that we provide the bearer auth token as another header compared to the default Authorization header [change will happen in a subsequent PR and once Unified Model Gateway accounts for this fact as well]).
  • http_client parameter won't be in a deprecated state anymore. We will continue using it as expected.
  • Removal of timeout parameter, we get the values for timeouts from the http_client parameter.
  • Initialization for OpenAI clients follows the old pattern not breaking the Impersonating JWT (OBO token). The current implementation is not working because OpenAI re-writes all the header values when we try to modify the Authorization header as well.

…lients; 'http_client' should be configured outside of the factory method.
@mgiannakopoulos mgiannakopoulos changed the title fix: Headers not propagated correctly for OpenAI requests. fix: Impersonating JWT (obo) header not propagated correctly for OpenAI requests. Dec 3, 2025
@nunogoncalves03
Copy link
Member

Does this PR affect chat factory initialization time for analyst servers?

@mgiannakopoulos
Copy link
Contributor Author

mgiannakopoulos commented Dec 3, 2025

Does this PR affect chat factory initialization time for analyst servers?

No, it doesn't. The existing gains should be present and intact with those changes.

@kesmit13 kesmit13 merged commit e496d96 into main Dec 3, 2025
11 checks passed
@kesmit13 kesmit13 deleted the MCDB-86327-fixes branch December 3, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants