-
Notifications
You must be signed in to change notification settings - Fork 22
fix: Impersonating JWT (obo) header not propagated correctly for OpenAI requests. #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lients; 'http_client' should be configured outside of the factory method.
Prudhvi0717
approved these changes
Dec 3, 2025
Member
|
Does this PR affect chat factory initialization time for analyst servers? |
Contributor
Author
No, it doesn't. The existing gains should be present and intact with those changes. |
kesmit13
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIth this change we:
http_clientin the factory methods and ensuring that we provide the bearer auth token as another header compared to the defaultAuthorizationheader [change will happen in a subsequent PR and once Unified Model Gateway accounts for this fact as well]).http_clientparameter won't be in a deprecated state anymore. We will continue using it as expected.timeoutparameter, we get the values for timeouts from thehttp_clientparameter.Authorizationheader as well.