Feature: Unify sample access #121
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When reading from a SigMF (.sigmf) archive, slicing and reading entire file worked, but not reading specific sample count * add test for archive read_samples and refactor related tests
* Make slicing equivalent to reading for integer types * e.g. meta[0:10] == meta.read_samples(count=10) * Breaking API Change: autoscale and raw_components parameters removed from read methods * Move autoscale configuration from method parameters to SigMFFile constructor * Remove already deprecated raw_components parameter from all methods * Update read_samples() and read_samples_in_capture() to use instance autoscale setting * Add autoscale support to fromfile(), fromarchive(), and SigMFArchiveReader * Simplify __getitem__ with unified scaling behavior for consistency * increment minor version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overdue fix that makes memory slices match read_samples behavior in all cases.
Currently blocked by PR #116.
Closes issue #60.
Introduces a breaking API change to rarely used kwargs (
autoscaleandraw_components) fromSigMFFile.read_samples(). As such I also increment minor version.