Detect unqualified static access in global scope #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janedbal
force-pushed
the
fix/unqualified-static-access-224
branch
from
2b655f5 to
52fe123
Compare
janedbal
requested changes
Nov 25, 2025
JanTvrdik
force-pushed
the
fix/unqualified-static-access-224
branch
from
52fe123 to
d960227
Compare
Fix #224: Classes used with static access patterns like `Foo::class`, `Foo::method()`, or `Foo::CONSTANT` in global scope (no namespace) were not detected when the class was not in `$knownSymbols`. This caused false positives where packages with such usages were reported as "unused dependencies". The fix adds detection for unqualified class names followed by `::` in global scope, similar to how unqualified function calls are handled. Note: `self`, `parent`, and `static` are already filtered by the Analyser via `$ignoredSymbols`.
JanTvrdik
force-pushed
the
fix/unqualified-static-access-224
branch
from
d960227 to
7506983
Compare
janedbal
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Foo::class,Foo::method(), orFoo::CONSTANTin global scope when the class is not in$knownSymbols::classProblem
When using code like:
If
ThInCacheInterfacewas not in$knownSymbols, it would not be detected as a class usage. This caused packages to be incorrectly flagged as "unused dependencies".Solution
Added detection for unqualified class names followed by
::in global scope, similar to the existing handling for unqualified function calls.Test plan
::class,::staticMethod(), and::CONSTANTpatterns inglobal-namespace.phpextensions-global.phpexpectations forZipArchive::classwhich is now detectedcomposer checkpasses