Skip to content

added role 'presentation' to navigation li tag #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added role 'presentation' to navigation li tag #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/navbar_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def menu_group(options={}, &block)
def menu_item(name=nil, path="#", *args, &block)
path = name || path if block_given?
options = args.extract_options!
content_tag :li, :class => is_active?(path, options) do
content_tag :li, :role => "presentation", :class => is_active?(path, options) do
if block_given?
link_to path, options, &block
else
Expand Down
7 changes: 7 additions & 0 deletions spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@
with_tag(:a, text: " Home", with: { href: "/"})
}
end

it "should return a link with role 'presentation' attribute" do
allow(self).to receive(:current_page?) { false }

element = menu_item("Home", "/")
expect(element).to have_tag(:li, with: {role: "presentation"})
end
end

describe "drop_down" do
Expand Down