Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions impl/runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,24 @@ func runWorkflow(t *testing.T, workflowPath string, input, expectedOutput map[st
return output, err
}

func runWorkflowExpectString(t *testing.T, workflowPath string, input interface{}) (output interface{}, err error) {
// Read the workflow YAML from the testdata directory
yamlBytes, err := os.ReadFile(filepath.Clean(workflowPath))
assert.NoError(t, err, "Failed to read workflow YAML file")

// Parse the YAML workflow
workflow, err := parser.FromYAMLSource(yamlBytes)
assert.NoError(t, err, "Failed to parse workflow YAML")

// Initialize the workflow runner
runner, err := NewDefaultRunner(workflow)
assert.NoError(t, err)

// Run the workflow
output, err = runner.Run(input)
return output, err
}

func assertWorkflowRun(t *testing.T, expectedOutput map[string]interface{}, output interface{}) {
if expectedOutput == nil {
assert.Nil(t, output, "Expected nil Workflow run output")
Expand Down
2 changes: 2 additions & 0 deletions impl/task_runner_do.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ func NewTaskRunner(taskName string, task model.Task, workflowDef *model.Workflow
return NewCallHttpRunner(taskName, t)
case *model.ForkTask:
return NewForkTaskRunner(taskName, t, workflowDef)
case *model.RunTask:
return NewRunTaskRunner(taskName, t)
default:
return nil, fmt.Errorf("unsupported task type '%T' for task '%s'", t, taskName)
}
Expand Down
169 changes: 169 additions & 0 deletions impl/task_runner_run.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,169 @@
// Copyright 2025 The Serverless Workflow Specification Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package impl

import (
"bytes"
"errors"
"fmt"
"os"
"os/exec"
"strings"

"github.com/serverlessworkflow/sdk-go/v3/impl/expr"
"github.com/serverlessworkflow/sdk-go/v3/model"
)

type RunTaskRunner struct {
Task *model.RunTask
TaskName string
}

func (d *RunTaskRunner) GetTaskName() string {
return d.TaskName
}

// RunTaskRunnable defines the interface for running a subtask for RunTask.
type RunTaskRunnable interface {
RunTask(taskConfiguration *model.RunTaskConfiguration, support *TaskSupport, input interface{}) (output interface{}, err error)
}

func NewRunTaskRunner(taskName string, task *model.RunTask) (*RunTaskRunner, error) {

if task == nil {
return nil, model.NewErrValidation(fmt.Errorf("no set configuration provided for RunTask %s", taskName), taskName)
}

return &RunTaskRunner{
Task: task,
TaskName: taskName,
}, nil
}

func (d *RunTaskRunner) Run(input interface{}, taskSupport TaskSupport) (output interface{}, err error) {

if d.Task.Run.Shell != nil {
shellTask := NewRunTaskShell()
return shellTask.RunTask(d, input, taskSupport)
}

return nil, fmt.Errorf("no set configuration provided for RunTask %s", d.TaskName)

}

// ProcessResult Describes the result of a process.
type ProcessResult struct {
Stdout string
Stderr string
Code int
}

// NewProcessResult creates a new ProcessResult instance.
func NewProcessResult(stdout, stderr string, code int) *ProcessResult {
return &ProcessResult{
Stdout: stdout,
Stderr: stderr,
Code: code,
}
}

// RunTaskShell defines the shell configuration for RunTask.
// It implements the RunTask.shell definition.
type RunTaskShell struct {
}

// NewRunTaskShell creates a new RunTaskShell instance.
func NewRunTaskShell() *RunTaskShell {
return &RunTaskShell{}
}

func (shellTask *RunTaskShell) RunTask(r *RunTaskRunner, input interface{}, taskSupport TaskSupport) (interface{}, error) {
await := r.Task.Run.Await
shell := r.Task.Run.Shell
var cmdStr string

if shell != nil {
cmdStr = shell.Command
}

if cmdStr == "" {
return nil, model.NewErrValidation(fmt.Errorf("no command provided for RunTask shell: %s ", r.TaskName), r.TaskName)
}

if shell.Environment != nil {
for key, value := range shell.Environment {
evaluated, ok := expr.TraverseAndEvaluate(value, input, taskSupport.GetContext())
if ok != nil {
return nil, model.NewErrRuntime(fmt.Errorf("error evaluating environment variable value for RunTask shell: %s", r.TaskName), r.TaskName)
}

err := os.Setenv(key, evaluated.(string))
if err != nil {
return nil, model.NewErrRuntime(fmt.Errorf("error setting environment variable for RunTask shell: %s", r.TaskName), r.TaskName)
}
}
}

evaluated, err := expr.TraverseAndEvaluate(cmdStr, input, taskSupport.GetContext())
if err != nil {
return nil, model.NewErrRuntime(fmt.Errorf("error evaluating command for RunTask shell: %s", r.TaskName), r.TaskName)
}

cmdEvaluated, ok := evaluated.(string)
if !ok {
return nil, model.NewErrRuntime(fmt.Errorf("expected evaluated command to be a string, but got a different type"), r.TaskName)
}

if await != nil && !*await {
go func() {
cmd := exec.Command("sh", "-c", cmdEvaluated)
_ = cmd.Start()
cmd.Wait()
}()
return input, nil
}

cmd := exec.Command("sh", "-c", cmdEvaluated)
var stdout, stderr bytes.Buffer
cmd.Stdout = &stdout
cmd.Stderr = &stderr

err = cmd.Run()
exitCode := 0
if err != nil {
var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
exitCode = exitErr.ExitCode()
}
} else if cmd.ProcessState != nil {
exitCode = cmd.ProcessState.ExitCode()
}

stdoutStr := strings.TrimSpace(stdout.String())
stderrStr := strings.TrimSpace(stderr.String())

switch r.Task.Run.Return {
case "all":
return NewProcessResult(stdoutStr, stderrStr, exitCode), nil
case "stderr":
return stdoutStr, nil
case "code":
return exitCode, nil
case "none":
return nil, nil
default:
return stdoutStr, nil
}
}
Loading