serpapi.HTTPError missing the essential status code and error
#22
+66
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances the serpapi.HTTPError exception class to expose essential diagnostic information—specifically the HTTP status code and error message—making it easier for API consumers to handle different error scenarios according to SerpApi's documented Status and Error Codes.
Key Changes:
- Added
status_codeanderrorproperties toHTTPErrorby implementing a custom__init__method - Added unit tests to verify the new exception attributes work correctly
- Updated integration tests to validate the new properties in real-world scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| serpapi/exceptions.py | Implements custom __init__ for HTTPError to extract and store status_code and error from the HTTP response |
| tests/test_exceptions.py | Adds new unit test file with test coverage for the enhanced HTTPError exception properties |
| tests/test_integration.py | Updates existing integration tests to validate both status_code and error attributes in real API failure scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #17
The status code is essential to determine the issue with the API, which we documented in Status and Error Codes. This PR add the info to the
serpapi.HTTPErrorexception.