Skip to content

[fix] workaround bug in cereal #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
h-2 merged 1 commit into from
Nov 10, 2022
Merged

[fix] workaround bug in cereal #197

h-2 merged 1 commit into from
Nov 10, 2022

Conversation

@h-2
Copy link
Member

@h-2 h-2 commented Nov 10, 2022

Can you check the (de)serialisation performance with this branch?

@h-2 h-2 requested a review from sarahet November 10, 2022 19:12
@sarahet
Copy link
Member

sarahet commented Nov 10, 2022

Clang format is failing 🙂

@sarahet
Copy link
Member

sarahet commented Nov 10, 2022

Index loading time:

This branch - 12.558s
This branch with #191 - 9.899s
@SGSSGene's workaround and #191 - 10.4s

sarahet
sarahet approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@sarahet sarahet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-2 h-2 merged commit 28d3b69 into seqan:lambda3 Nov 10, 2022
@h-2
Copy link
Member Author

h-2 commented Nov 10, 2022

Thanks for evaluating it!

@h-2
Copy link
Member Author

h-2 commented Nov 10, 2022

This is the upstream issue: USCiLab/cereal#769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarahet sarahet sarahet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-2 @sarahet