fix: improve error handling in toBigInt function #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGuilding
requested changes
Aug 7, 2025
Contributor
JohnGuilding
left a comment
JohnGuilding
left a comment
There was a problem hiding this comment.
Cheers @Galoretka. One small suggestion
Co-authored-by: John Guilding <54913924+JohnGuilding@users.noreply.github.com>
Contributor
Author
Done |
vplasencia
approved these changes
Aug 7, 2025
Member
vplasencia
left a comment
vplasencia
left a comment
There was a problem hiding this comment.
Looks great! Thank you very much @Galoretka
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Semaphore Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TypeError when error.message is undefined by using optional chaining
and fallback to error.toString() for safer error handling.