Added lerp for smooth transition of walk speed #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selgesel
reviewed
Jul 23, 2024
Owner
selgesel
left a comment
selgesel
left a comment
There was a problem hiding this comment.
Hey, sorry for the super late reply, and thanks a lot for the contribution!
Added some notes regarding the lerp step and indentations, but otherwise looks pretty good, thanks!
| player.anim_tree.set("parameters/OnGround/blend_position", player.horizontal_velocity.length() / 10.0) | ||
| # set the checked ground blend position to player's horizontal speed divided by 10, the running speed | ||
| # lerp for smooth blending | ||
| var new_blend_pos = lerp(player.anim_tree.get("parameters/OnGround/blend_position"), player.horizontal_velocity.length() / 10.0, 0.1) |
Owner
There was a problem hiding this comment.
While playing with your changes on my (very choppy) Mac I found the hardcoded 0.1 lerp step to cause a little bit of jerkiness. 10.0 * delta worked much more smoothly, so can you please use that instead?
| # set the checked ground blend position to player's horizontal speed divided by 10, the running speed | ||
| # lerp for smooth blending | ||
| var new_blend_pos = lerp(player.anim_tree.get("parameters/OnGround/blend_position"), player.horizontal_velocity.length() / 10.0, 0.1) | ||
| player.anim_tree.set("parameters/OnGround/blend_position", new_blend_pos) |
Owner
There was a problem hiding this comment.
Can you please change the indentation of the affected lines from tabs to spaces? You can do that by selecting the 4 affected lines and hitting Ctrl+i or Cmd+i
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.