Skip to content

Fix alert query #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

Fix alert query #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
565690f
feat: enabling additional variable option for alert query
kuntalkumarbasu May 20, 2025
0c19014
fix: syntax missing brackets
kuntalkumarbasu May 20, 2025
5e1aab2
fix syntax
kuntalkumarbasu May 20, 2025
8fc4c1b
fix syntax
kuntalkumarbasu May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion monitoring.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ locals {
var.enable_glue_create ? lower(var.glue_create_config.sqs_queue_name_dl) : local.base_dlq_name,
var.enable_glue_sync ? lower(var.glue_sync_config.sqs_queue_name_dl) : local.base_dlq_name,
]
additional_query_conditions = length(var.monitoring_query_conditions) > 0 ? ", ${var.monitoring_query_conditions}" : ""
}

resource "datadog_monitor" "dead_letters_monitor" {
Expand All @@ -17,7 +18,7 @@ resource "datadog_monitor" "dead_letters_monitor" {
dead_letters_queue_name = each.key
notify = join(", ", var.dl_alert_recipients)
})
query = "avg(last_1h):avg:aws.sqs.approximate_number_of_messages_visible{queuename:${each.key}} > ${var.dl_critical}"
query = "avg(last_1h):avg:aws.sqs.approximate_number_of_messages_visible{queuename:${each.key}${local.additional_query_conditions}} > ${var.dl_critical}"

monitor_thresholds {
warning = var.dl_warning
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,12 @@ variable "tags_monitoring" {
description = "A list of tags to assign to the monitoring resource"
}

variable "monitoring_query_conditions" {
type = string
description = "Monitoring query conditions a comma peratde key:value pair list"
default = ""
}

variable "enable_aws_glue_catalog_table" {
type = bool
description = "Enable glue catalog table"
Expand Down
Loading