Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions monitoring.tf
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
locals {
enable_dead_letters_monitoring = var.enabled_dead_letters_monitoring
dl_warning = var.dl_warning
dl_critical = var.dl_critical
dlq_to_monitor = [
local.enable_group_events ? var.sqs_fifo_DL_queue_name : var.sqs_queue_name_dl,
var.enable_glue_create ? var.glue_create_config.sqs_queue_name_dl : "",
Expand All @@ -10,7 +7,7 @@ locals {
}

resource "datadog_monitor" "dead_letters_monitor" {
for_each = local.enable_dead_letters_monitoring ? toset(local.dlq_to_monitor) : []
for_each = var.enabled_dead_letters_monitoring ? toset(local.dlq_to_monitor) : []

type = "metric alert"
name = "${each.key}-monitor"
Expand All @@ -22,10 +19,9 @@ resource "datadog_monitor" "dead_letters_monitor" {
query = "avg(last_1h):avg:aws.sqs.approximate_number_of_messages_visible{queuename:${each.key}} > ${var.dl_critical}"

monitor_thresholds {
warning = local.dl_warning
warning_recovery = local.dl_warning - 1
critical = local.dl_critical
critical_recovery = local.dl_critical - 1
warning = var.dl_warning
critical = var.dl_critical
ok = var.dl_ok
}

notify_no_data = false
Expand Down
14 changes: 9 additions & 5 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -256,17 +256,21 @@ variable "dl_alert_message" {
}

variable "dl_warning" {
type = number
default = 0
type = any
default = ""
description = "Dead letters warning value"
}

variable "dl_critical" {
type = number
default = 0
type = any
default = ""
description = "Dead letters critical value"
}
variable "dl_ok" {
type = any
default = ""
description = "Dead letters critical value"
}

variable "tags_monitoring" {
type = list(string)
default = []
Expand Down
Loading