Skip to content

[DEVPLAT-3096] Verify dependencies #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 4, 2025
Merged

[DEVPLAT-3096] Verify dependencies #141

merged 4 commits into from
Mar 4, 2025

Conversation

@Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Mar 4, 2025 •
edited
Loading

Description

In this PR, we add the mage deps:check command to check if the Go dependencies are properly updated. We also add a go mod verify step to the Docker build layer to verify the downloaded modules.

Also, we update the ubuntu version of the actions runner, as the 20.04 will be unsupported by 2025-04-01.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep requested a review from a team as a code owner March 4, 2025 14:42
@Neurostep Neurostep requested a review from cktaylor March 4, 2025 14:42
@Neurostep Neurostep force-pushed the maksimt/DEVPLAT-3096/dependencies-check branch from e02a673 to bcdf303 Compare March 4, 2025 14:53
terranisu
terranisu approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Neurostep Neurostep merged commit fccab87 into main Mar 4, 2025
7 checks passed
@Neurostep Neurostep deleted the maksimt/DEVPLAT-3096/dependencies-check branch March 4, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terranisu terranisu terranisu approved these changes

@cktaylor cktaylor Awaiting requested review from cktaylor cktaylor is a code owner automatically assigned from scribd/service-foundations

+1 more reviewer

@basmscribd basmscribd basmscribd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neurostep @terranisu @basmscribd