-
Notifications
You must be signed in to change notification settings - Fork 8
Implement 'no-limit' and 'max' options for CPU/Memory #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a3518f to
e30cb2d
Compare
3dcfa63 to
7980799
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 79.67% 78.85% -0.83%
==========================================
Files 15 18 +3
Lines 1166 1305 +139
==========================================
+ Hits 929 1029 +100
- Misses 204 239 +35
- Partials 33 37 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
08b0824 to
664a9da
Compare
c7703c3 to
6f40a32
Compare
…rating new state utilities for validation and conversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements new “no-limit” and “max” options for CPU and memory settings in minikube so that users can easily specify an upper bound (or absence thereof) for resource allocation. Key changes include updates to the core library (lib) and state utilities for CPU and memory conversion/validation, enhanced tests to cover these new options, and updates to the provider schema and generator overrides.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| minikube/lib/memory.go | Added basic memory limit functionality with new options (“no-limit”, “max”). |
| minikube/state_utils/* | Introduced CPU and memory converters/validators along with updated tests. |
| minikube/state_utils/resource_size.go | Modified resource size conversion/validation to return errors instead of panicking. |
| minikube/schema_cluster.go | Updated schema for “cpus” and “memory” to use string types and new conversion functions. |
| minikube/generator/schema_builder.go | Adjusted schema builder overrides to reflect the new “max” and “no-limit” options. |
| minikube/resource_cluster*.go | Updated cluster resource creation to use the new state utility functions. |
Closes #181