Skip to content

Conversation

@scott-the-programmer
Copy link
Owner

Closes #181

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 74.67532% with 39 lines in your changes missing coverage. Please review.

Project coverage is 78.85%. Comparing base (5aaebe0) to head (3eb956e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
minikube/state_utils/cpu.go 75.47% 13 Missing ⚠️
minikube/state_utils/memory.go 79.66% 9 Missing and 3 partials ⚠️
minikube/lib/memory.go 0.00% 11 Missing ⚠️
minikube/resource_cluster.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   79.67%   78.85%   -0.83%     
==========================================
  Files          15       18       +3     
  Lines        1166     1305     +139     
==========================================
+ Hits          929     1029     +100     
- Misses        204      239      +35     
- Partials       33       37       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scott-the-programmer scott-the-programmer marked this pull request as ready for review March 16, 2025 15:19
…rating new state utilities for validation and conversion
@scott-the-programmer scott-the-programmer requested review from Copilot and removed request for Copilot March 16, 2025 17:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements new “no-limit” and “max” options for CPU and memory settings in minikube so that users can easily specify an upper bound (or absence thereof) for resource allocation. Key changes include updates to the core library (lib) and state utilities for CPU and memory conversion/validation, enhanced tests to cover these new options, and updates to the provider schema and generator overrides.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
minikube/lib/memory.go Added basic memory limit functionality with new options (“no-limit”, “max”).
minikube/state_utils/* Introduced CPU and memory converters/validators along with updated tests.
minikube/state_utils/resource_size.go Modified resource size conversion/validation to return errors instead of panicking.
minikube/schema_cluster.go Updated schema for “cpus” and “memory” to use string types and new conversion functions.
minikube/generator/schema_builder.go Adjusted schema builder overrides to reflect the new “max” and “no-limit” options.
minikube/resource_cluster*.go Updated cluster resource creation to use the new state utility functions.

@scott-the-programmer scott-the-programmer enabled auto-merge (squash) March 16, 2025 17:12
@scott-the-programmer scott-the-programmer merged commit 6239f24 into main Mar 16, 2025
1 check passed
@scott-the-programmer scott-the-programmer deleted the max-no-limit branch March 16, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow "no-limit" and "max" for cpus and memory when driver is Docker/Podman

2 participants