Skip to content

upgrade provider to use minikube 1.34 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

upgrade provider to use minikube 1.34 #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1907600
Bump minikube version to v1.34.0 and update related dependencies
scott-the-programmer Feb 20, 2025
fac49c4
Update minikube ISO URL to version v1.34.0 in tests
scott-the-programmer Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bootstrap/install-driver.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e

VERSION="v1.33.0"
VERSION="v1.34.0"

SCRIPT_DIR="$( cd -- "$( dirname -- "${BASH_SOURCE[0]:-$0}"; )" &> /dev/null && pwd 2> /dev/null; )";

Expand Down
5 changes: 3 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
module github.com/scott-the-programmer/terraform-provider-minikube

go 1.22.0
toolchain go1.22.9
go 1.22.7

toolchain go1.23.3

require (
github.com/docker/machine v0.16.2
Expand Down
2 changes: 1 addition & 1 deletion minikube/lib/minikube_release_resolver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ func TestGetMinikubeIso(t *testing.T) {
}{
{
name: "Retrieves minikube iso",
want: fmt.Sprintf("https://github.com/kubernetes/minikube/releases/download/v1.33.0/minikube-v1.33.0-%s.iso", runtime.GOARCH),
want: fmt.Sprintf("https://github.com/kubernetes/minikube/releases/download/v1.34.0/minikube-v1.34.0-%s.iso", runtime.GOARCH),
},
}
for _, tt := range tests {
Expand Down
4 changes: 2 additions & 2 deletions minikube/schema_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ var (
Optional: true,
ForceNew: true,

Default: "gcr.io/k8s-minikube/kicbase:v0.0.44@sha256:eb04641328b06c5c4a14f4348470e1046bbcf9c2cbc551486e343d3a49db557e",
Default: "gcr.io/k8s-minikube/kicbase:v0.0.45@sha256:81df288595202a317b1a4dc2506ca2e4ed5f22373c19a441b88cfbf4b9867c85",
},

"binary_mirror": {
Expand Down Expand Up @@ -598,7 +598,7 @@ var (

"kubernetes_version": {
Type: schema.TypeString,
Description: "The Kubernetes version that the minikube VM will use (ex: v1.2.3, 'stable' for v1.30.0, 'latest' for v1.30.0). Defaults to 'stable'.",
Description: "The Kubernetes version that the minikube VM will use (ex: v1.2.3, 'stable' for v1.31.0, 'latest' for v1.31.0). Defaults to 'stable'.",

Optional: true,
ForceNew: true,
Expand Down
2 changes: 1 addition & 1 deletion minikube/version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package version

const (
Version = "v1.33.0" // matches k8s.io/minikube v1.33.0
Version = "v1.34.0" // matches k8s.io/minikube v1.34.0
)