-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add check-eol-cached hook #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added tests, all new code is covered |
|
Thanks for this! I have only been able to do a quick scan & will try to take a look sometime this week. A couple things at a glance:
A bit more broadly, I don't think there's really a reason to carry around a second cache file that's the same as what's already present just with less fields per release. There's never going to be a particularly large amount of data so I'd rather just pull the necessary information from the already existing cache. |
Fair! (btw, I think
Forgot that!
Makes sense, I didn't think about that. How about including a |
I think using the already existing |
Ah, of course. |
|
Done, that was much simpler |
Closes #8
Example:
Changes:
Create a pull request instead of opening an issue because it bugged me, can revertSplit up getting EOL versions so it can be reused bybump_cache.py--cachedflag that usesa cached list of EOL versionsthestatusof the release instead of relying on the timeAdds the new cache tobump_cache.pyand generate the initial one.TODO:
Add automatic version publishing if desiredWhat do you think?