-
Notifications
You must be signed in to change notification settings - Fork 129
chore: remove check_is_fitted scikit-learn dependence #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
60fbf22
init check_is_fitted mapie function
hmaissoro aed8170
add alias to sklearn check_is_fitted
hmaissoro ade9547
remore sklearn check_is_fitted func
hmaissoro ff7489c
remore sklearn check_is_fitted
hmaissoro c670d22
replace sk_leatn's check_is_fitted
hmaissoro b60f15e
remove sk_leatn's check_is_fitted
hmaissoro 92100cc
replace sk_leatn's check_is_fitted
hmaissoro 675b95b
remove sklearn dependence
hmaissoro 29fae7a
use mapie check_is_fitted function
hmaissoro ea484b4
use mapie function
hmaissoro a908c70
replace by mapie function
hmaissoro e12a55a
reduce comment
hmaissoro b873640
add test
hmaissoro 545809b
remove sklearn's check_is_fitted dependence
hmaissoro 33c548e
update
hmaissoro 0c31be1
more self._is_fitted bool
hmaissoro 9d7431e
add is_fitted checking
hmaissoro f59d422
import mapie NotFittedError
hmaissoro cedfd6e
import sklearn's NotFittedError as sk_NotFittedError
hmaissoro ee51834
Update HISTORY.rst
hmaissoro c91d532
add docstring
hmaissoro 6135b07
add docstring
hmaissoro d434c43
add docstring
hmaissoro 08f183f
no cover
hmaissoro 72a7e4d
Merge branch 'master' into user-xp/remove-check_is_fitted
hmaissoro 0026e07
test is_fitted parameter directly
hmaissoro b24a45a
is_fitted is now covered
hmaissoro aa4f423
correct test
hmaissoro 05b23be
user_model_check : add check function
hmaissoro 5857eb1
user_model_check : add tests
hmaissoro ed1cfb3
replace sklearn's check_is_fitted
hmaissoro 6b443eb
replace sklearn's check_is_fitted
hmaissoro 49acf1a
replace sklearn's check_is_fitted
hmaissoro 5d17fec
replace sklearn's check_is_fitted
hmaissoro cb19dad
add newline at end of file
hmaissoro e8fc5d0
accept two expectations
hmaissoro f9488bd
filter the warning since it is expected
hmaissoro d42ad5b
change implementation
hmaissoro bfb623e
update check_use_model_is_fitted's function is fitter
hmaissoro 88d2bc8
filter expected warning and remove sklearn's NotFittedError dependence
hmaissoro 24f7c53
remove unnecessary check_is_fitted
hmaissoro ac478f9
leave check_is_fitted in .predict methods because of tests
hmaissoro aa28ede
change regex
hmaissoro 31527e6
add test for coverage
hmaissoro afa7904
formatting
hmaissoro 82f8516
remove remaining sklearn's check_is_fitted dependence
hmaissoro a4176d4
remove sklearn's check_is_fitted
hmaissoro 167661c
remove sklearn's check_is_fitted in tests
hmaissoro f32e3f6
remove sklearn's check_is_fitted
hmaissoro e187b96
update the docstring
hmaissoro 433c83d
add sklearn in the name of check_user_model_is_fitted
hmaissoro e266f9c
update name
hmaissoro 7cc2325
remove not covered ligne
hmaissoro a6e914c
remove unnecessary flag
hmaissoro 47dc187
Raise warning instead of error
hmaissoro 6fabe85
adjust flag usage
hmaissoro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.