Skip to content

Commit 2f36e71

Browse files
MK8S-25: Further factorize index.html file path generation
Simplify _get_index_file_paths() to use _get_repository_directories() output: - Eliminates duplicate directory listing logic between the two methods - _get_index_file_paths() now simply appends INDEX_HTML_FILENAME to each directory - Maintains single source of truth for all repository directory paths - Reduces code duplication and improves maintainability
1 parent c23a3a8 commit 2f36e71

File tree

1 file changed

+3
-23
lines changed

1 file changed

+3
-23
lines changed

buildchain/buildchain/targets/repository.py

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -235,31 +235,11 @@ def _get_index_file_paths(self) -> List[Path]:
235235
Returns:
236236
List of all index.html file paths that should be created/cleaned
237237
"""
238-
# Repository-specific index files
239-
index_files = [
240-
self.rootdir / self.INDEX_HTML_FILENAME,
241-
self.rootdir / self.ARCH / self.INDEX_HTML_FILENAME,
238+
return [
239+
directory / self.INDEX_HTML_FILENAME
240+
for directory in self._get_repository_directories()
242241
]
243242

244-
# Add saltenv index files for scality repository
245-
saltenv_dir, top_saltenv_dir = self._get_saltenv_directories()
246-
if saltenv_dir and top_saltenv_dir:
247-
index_files.extend(
248-
[
249-
# Repository-level saltenv structure
250-
saltenv_dir / self.INDEX_HTML_FILENAME,
251-
saltenv_dir / "redhat" / self.INDEX_HTML_FILENAME,
252-
saltenv_dir
253-
/ "redhat"
254-
/ str(self._releasever)
255-
/ self.INDEX_HTML_FILENAME,
256-
# Top-level saltenv (for health check)
257-
top_saltenv_dir / self.INDEX_HTML_FILENAME,
258-
]
259-
)
260-
261-
return index_files
262-
263243
def _get_repository_directories(self) -> List[Path]:
264244
"""Get all repository directories that need index.html files.
265245

0 commit comments

Comments
 (0)