MK8S-25: Complete factorization of repository index.html file handling

Eliminates code duplication by centralizing all index.html file path logic:
- Added _get_index_file_paths() method for consistent file path listing
- Added _get_repository_directories() method for consistent directory listing
- Updated clean(), create_index(), and targets list to use centralized methods
- Ensures creation, cleanup, and task dependencies all reference same file paths

Author: rdebay-scality

buildchain/buildchain/targets/repository.py

@@ -229,76 +229,22 @@ def _get_saltenv_directories(self) -> tuple:
         )
         return saltenv_dir, top_saltenv_dir
 
-    def create_index_files(self) -> types.TaskDict:
-        """Create index.html files for repository directories."""
-
-        def clean() -> None:
-            """Delete the index.html files created by this task."""
-            # Clean repository-specific index files
-            index_files = [
-                self.rootdir / self.INDEX_HTML_FILENAME,
-                self.rootdir / self.ARCH / self.INDEX_HTML_FILENAME,
-            ]
-            # Clean shared directory index files if this is scality repo
-            saltenv_dir, top_saltenv_dir = self._get_saltenv_directories()
-            if saltenv_dir and top_saltenv_dir:
-                index_files.extend(
-                    [
-                        # Repository-level saltenv structure
-                        saltenv_dir / self.INDEX_HTML_FILENAME,
-                        saltenv_dir / "redhat" / self.INDEX_HTML_FILENAME,
-                        saltenv_dir
-                        / "redhat"
-                        / str(self._releasever)
-                        / self.INDEX_HTML_FILENAME,
-                        # Top-level saltenv (for health check)
-                        top_saltenv_dir / self.INDEX_HTML_FILENAME,
-                    ]
-                )
-
-            # Actually remove the index.html files
-            for index_file in index_files:
-                if index_file.exists():
-                    index_file.unlink()
-
-        def create_index() -> None:
-            """Create empty index.html files in repository directories."""
-            repository_directories = [
-                self.rootdir,  # Repository root (e.g., metalk8s-scality-el8)
-                self.rootdir / self.ARCH,  # Architecture directory (e.g., x86_64)
-            ]
-
-            # Also create shared directory index files, but only from scality repo
-            # to avoid doit task conflicts between multiple repositories
-            saltenv_dir, top_saltenv_dir = self._get_saltenv_directories()
-            if saltenv_dir and top_saltenv_dir:
-                repository_directories.extend(
-                    [
-                        # Repository-level saltenv structure
-                        saltenv_dir,
-                        saltenv_dir / "redhat",
-                        saltenv_dir / "redhat" / str(self._releasever),
-                        # Top-level saltenv (for health check)
-                        top_saltenv_dir,
-                    ]
-                )
-
-            for repository_directory in repository_directories:
-                # Create directory if it doesn't exist, then create index.html
-                repository_directory.mkdir(parents=True, exist_ok=True)
-                index_file = repository_directory / self.INDEX_HTML_FILENAME
-                index_file.touch()
-                # Set readable permissions for nginx
-                index_file.chmod(0o644)
+    def _get_index_file_paths(self) -> List[Path]:
+        """Get all index.html file paths for this repository.
 
-        # Build targets list - include shared directories only for scality repo
-        targets = [
+        Returns:
+            List of all index.html file paths that should be created/cleaned
+        """
+        # Repository-specific index files
+        index_files = [
             self.rootdir / self.INDEX_HTML_FILENAME,
             self.rootdir / self.ARCH / self.INDEX_HTML_FILENAME,
         ]
+
+        # Add saltenv index files for scality repository
         saltenv_dir, top_saltenv_dir = self._get_saltenv_directories()
         if saltenv_dir and top_saltenv_dir:
-            targets.extend(
+            index_files.extend(
                 [
                     # Repository-level saltenv structure
                     saltenv_dir / self.INDEX_HTML_FILENAME,
@@ -312,6 +258,59 @@ def create_index() -> None:
                 ]
             )
 
+        return index_files
+
+    def _get_repository_directories(self) -> List[Path]:
+        """Get all repository directories that need index.html files.
+
+        Returns:
+            List of directory paths where index.html should be created
+        """
+        # Repository-specific directories
+        repository_directories = [
+            self.rootdir,  # Repository root (e.g., metalk8s-scality-el8)
+            self.rootdir / self.ARCH,  # Architecture directory (e.g., x86_64)
+        ]
+
+        # Add saltenv directories for scality repository
+        saltenv_dir, top_saltenv_dir = self._get_saltenv_directories()
+        if saltenv_dir and top_saltenv_dir:
+            repository_directories.extend(
+                [
+                    # Repository-level saltenv structure
+                    saltenv_dir,
+                    saltenv_dir / "redhat",
+                    saltenv_dir / "redhat" / str(self._releasever),
+                    # Top-level saltenv (for health check)
+                    top_saltenv_dir,
+                ]
+            )
+
+        return repository_directories
+
+    def create_index_files(self) -> types.TaskDict:
+        """Create index.html files for repository directories."""
+
+        def clean() -> None:
+            """Delete the index.html files created by this task."""
+            # Actually remove the index.html files
+            for index_file in self._get_index_file_paths():
+                if index_file.exists():
+                    index_file.unlink()
+
+        def create_index() -> None:
+            """Create empty index.html files in repository directories."""
+            for repository_directory in self._get_repository_directories():
+                # Create directory if it doesn't exist, then create index.html
+                repository_directory.mkdir(parents=True, exist_ok=True)
+                index_file = repository_directory / self.INDEX_HTML_FILENAME
+                index_file.touch()
+                # Set readable permissions for nginx
+                index_file.chmod(0o644)
+
+        # Build targets list using centralized method
+        targets = self._get_index_file_paths()
+
         task = self.basic_task
         task.update(
             {