chore(vcr): bump dnaeon/go vcr.v4 to 4.0.6 manually #3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps gopkg.in/dnaeon/go-vcr.v4 from 4.0.5 to 4.0.6. --- updated-dependencies: - dependency-name: gopkg.in/dnaeon/go-vcr.v4 dependency-version: 4.0.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3511 +/- ##
======================================
Coverage 1.76% 1.77%
======================================
Files 406 406
Lines 44434 44435 +1
======================================
+ Hits 784 787 +3
+ Misses 43562 43561 -1
+ Partials 88 87 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that appeared in the vcr-compressor with the update of dnaeon/go vcr.v4 from v4.0.5 to v4.0.6.
The
cassette.Newfunction doesn't set the MarshalFunc attribute inside the output cassette so the subsequent call tooutputCassette.Save()panicked because it calls the MarshalFunc.To prevent this, we set it manually right after creating the outputCassette.