-
Notifications
You must be signed in to change notification settings - Fork 156
feat(redis): add cluster connect command #5211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jremy42
wants to merge
9
commits into
master
Choose a base branch
from
feat/redis-connect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
384c8b6
feat(redis): add cluster connect command
jremy42 68afb9d
fix(redis): fix lint errors and regenerate golden files
jremy42 1469a91
docs(redis): regenerate documentation for cluster connect command
jremy42 5a8a22f
Merge branch 'master' into feat/redis-connect
jremy42 a32d236
fix(redis): use dynamic zones from SDK instead of hardcoded zones
jremy42 56989b9
docs(redis): fix examples to show private-network flag in documentation
jremy42 b385d39
test(redis): update golden file for cluster connect command examples
jremy42 92b761f
Merge branch 'master' into feat/redis-connect
jremy42 b653726
Merge branch 'master' into feat/redis-connect
jremy42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
cmd/scw/testdata/test-all-usage-redis-cluster-connect-usage.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| 🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲 | ||
| 🟥🟥🟥 STDERR️️ 🟥🟥🟥️ | ||
| Connect to a Redis cluster using locally installed redis-cli. The command will check if redis-cli is installed, download the certificate if TLS is enabled, and prompt for the password. | ||
|
|
||
| USAGE: | ||
| scw redis cluster connect <cluster-id ...> [arg=value ...] | ||
|
|
||
| EXAMPLES: | ||
| Connect to a Redis cluster | ||
| scw redis cluster connect 11111111-1111-1111-1111-111111111111 | ||
|
|
||
| Connect to a Redis cluster via private network | ||
| scw redis cluster connect 11111111-1111-1111-1111-111111111111 private-network=true | ||
|
|
||
| ARGS: | ||
| [private-network=false] Connect by the private network endpoint attached. | ||
| cluster-id UUID of the cluster | ||
| [cli-redis] Command line tool to use, default to redis-cli | ||
| [cli-args] Additional arguments to pass to redis-cli | ||
| [zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | pl-waw-1 | pl-waw-2) | ||
|
|
||
| FLAGS: | ||
| -h, --help help for connect | ||
|
|
||
| GLOBAL FLAGS: | ||
| -c, --config string The path to the config file | ||
| -D, --debug Enable debug mode | ||
| -o, --output string Output format: json or human, see 'scw help output' for more info (default "human") | ||
| -p, --profile string The config profile to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to have an argument passed through the command line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! The
cli-argsparameter allows passing additional arguments to redis-cli. Example:scw redis cluster connect <cluster-id> cli-args.0=--raw