Skip to content

Conversation

@jnmt
Copy link
Collaborator

@jnmt jnmt commented Dec 3, 2025

Description

This PR adds the create-namespace CLI command.

Related issues and/or PRs

Changes made

  • Add the create-namespace CLI command.
  • Remove the obsolete command, MultiLedgersValidation.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Added the create-namespace command.

Copilot AI review requested due to automatic review settings December 3, 2025 08:29
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jnmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the client-side tooling by introducing a dedicated command for creating namespaces. This new utility streamlines the process of setting up new namespaces, improving the overall manageability and user experience for interacting with the system.

Highlights

  • New Command Added: A new command-line tool, create-namespace, has been introduced to facilitate the creation of namespaces.
  • Core Logic Implementation: The core logic for creating namespaces is implemented in the new NamespaceCreation.java class, handling command-line arguments and interacting with the client service.
  • CLI Integration: The create-namespace command is integrated into the main ScalarDlCommandLine utility, making it accessible to users and categorized under a new 'manage namespaces' section.
  • Comprehensive Testing: Dedicated unit tests have been added for the NamespaceCreation command, ensuring its functionality and robustness across different scenarios, including gateway and non-gateway configurations, and error handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new "create-namespace" command, allowing users to create namespaces via the command-line client. The changes include updating the "build.gradle" file to define the new task, adding the "NamespaceCreation.java" class for the command logic, and integrating it into the "ScalarDlCommandLine" tool. Comprehensive unit tests for the new command and its integration have also been added, ensuring proper functionality and error handling. The overall implementation is clean and follows existing patterns.

Copilot finished reviewing on behalf of jnmt December 3, 2025 08:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new create-namespace command-line tool to the ScalarDL client, enabling users to create namespaces via the command line. The implementation follows established patterns in the codebase for command-line tools.

Key Changes

  • New NamespaceCreation command class that extends AbstractClientCommand and invokes ClientService.createNamespace()
  • Comprehensive test suite covering success cases, gateway/non-gateway configurations, and error handling
  • Integration of the new command into the ScalarDL command-line interface with proper help text and grouping

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
client/src/main/java/com/scalar/dl/client/tool/NamespaceCreation.java Implements the create-namespace command with --namespace option
client/src/test/java/com/scalar/dl/client/tool/NamespaceCreationTest.java Provides comprehensive test coverage following established test patterns
client/src/main/java/com/scalar/dl/client/tool/ScalarDlCommandLine.java Registers the new command and adds it to the "manage namespaces" section
client/src/test/java/com/scalar/dl/client/tool/ScalarDlCommandLineTest.java Updates expected help output to include the new command
client/build.gradle Configures build task and distribution for the new command, but unexpectedly removes MultiLedgersValidation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jnmt jnmt self-assigned this Dec 3, 2025
@jnmt jnmt added the enhancement New feature or request label Dec 3, 2025
@jnmt jnmt requested review from choplin and feeblefakie December 3, 2025 08:35
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants