Backport to branch(3) : Fix status code handling

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix status code handling #323
• Backported commit: 8458852

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport that refines the handling of status codes within the CommonService. It ensures that specific internal status codes are correctly translated into their corresponding gRPC status representations, improving error consistency and communication for various scenarios like invalid arguments or missing secrets.

Highlights

• Status Code Mapping: Added mappings for INVALID_ARGUMENT and SECRET_NOT_FOUND StatusCode enums to their respective gRPC status codes (io.grpc.Status.INVALID_ARGUMENT and io.grpc.Status.NOT_FOUND) within the CommonService.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds handling for the INVALID_ARGUMENT and SECRET_NOT_FOUND status codes, mapping them to the appropriate gRPC statuses. The change is logical and follows the existing code structure. However, the pull request is missing unit tests to verify the new mappings. Adding tests would improve the overall quality and prevent future regressions. I've added a comment with a detailed suggestion on how to implement these tests.

[gemini-code-assist]

While the new status code mappings are correct, there are no corresponding unit tests being added in CommonServiceTest.java to verify this. It would be good practice to add tests that throw LedgerException with StatusCode.INVALID_ARGUMENT and StatusCode.SECRET_NOT_FOUND and assert that the correct gRPC status is returned to the client. This would prevent future regressions and improve test coverage, as the current tests only check that onError is called, not which specific error is propagated.

For example, a test for INVALID_ARGUMENT could look like this (you will need to add imports for ArgumentCaptor, StatusRuntimeException, and assertEquals):

@Test
public void serve_LedgerExceptionWithInvalidArgument_ShouldCallOnErrorWithInvalidArgument() {
    // Arrange
    service = new CommonService(stats, gateKeeper);
    ThrowableConsumer<String> f =
        r -> {
          throw new LedgerException("test", StatusCode.INVALID_ARGUMENT);
        };
    String request = "test";
    ArgumentCaptor<StatusRuntimeException> captor = ArgumentCaptor.forClass(StatusRuntimeException.class);

    // Act
    service.serve(f, request, observerWithEmpty);

    // Assert
    verify(observerWithEmpty).onError(captor.capture());
    assertEquals(io.grpc.Status.Code.INVALID_ARGUMENT, captor.getValue().getStatus().getCode());
}

A similar test should be added for SECRET_NOT_FOUND.