Backport to branch(3.16) : Fix failure log writing issue in storage mode for Data Loader imports

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix failure log writing issue in storage mode for Data Loader imports #3189
• Backported commit: 7f9d80e

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This backport addresses a critical logging anomaly within the Data Loader's import process, guaranteeing that all import failures are reliably recorded regardless of specific raw data logging settings. Furthermore, it refines the content of these logs by introducing a conditional inclusion of raw source records, which prevents unnecessary data exposure and optimizes log verbosity.

Highlights

• Failure Log Writing Fix: Corrected an issue in the Data Loader where failure logs might not be written if the configuration for logging raw source records was disabled, ensuring all import failures are consistently logged.
• Conditional Raw Record Logging: Implemented a new mechanism to conditionally include raw source records in the ImportTargetResult objects. This ensures that raw data is only logged when explicitly configured, improving log efficiency and privacy.
• Enhanced Test Coverage: Added new unit tests to thoroughly validate the corrected failure logging behavior and the proper conditional inclusion of raw records in the logs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively fixes an issue where failure logs were not being written in storage mode when raw record logging was disabled. The changes correctly decouple failure logging from the raw record logging setting in both SingleFileImportLogger and SplitByDataChunkImportLogger. Additionally, the logic for including the raw record in the import results is now centralized in ImportTask through a new helper method, which improves maintainability. The new tests for SingleFileImportLogger are a good addition, though I have one suggestion to improve test coverage consistency.