Backport to branch(3) : Unify Get/Scan preparation logic for transaction reads and Serializable validation

[feeblefakie]

This is an automated backport of the following:

• Original PR: Unify Get/Scan preparation logic for transaction reads and Serializable validation #3113
• Backported commit: 477fba5

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors and unifies the preparation logic for Get and Scan operations within the Consensus Commit transaction manager. By centralizing the handling of conditions, especially the conversion to include 'before image' columns for transactional reads and serializable validation, the change aims to improve code maintainability and consistency across the core transaction components. This ensures that operations are correctly configured for storage interactions and validation checks.

Highlights

• Centralized Operation Preparation: The logic for preparing Get and Scan operations for storage reads and serializable validation has been centralized into new utility methods, prepareGetForStorage and prepareScanForStorage, within ConsensusCommitUtils.
• Conjunction Conversion for Before Images: The complex logic of converting conditions (conjunctions) to include 'before image' columns, crucial for transactional integrity, is now encapsulated in a dedicated convertConjunctions helper method in ConsensusCommitUtils.
• Reduced Code Duplication: The CrudHandler and Snapshot classes have been refactored to utilize these new utility methods, significantly reducing duplicated code related to operation preparation and condition handling.
• Streamlined Scan Limits: The prepareScanForStorage method now automatically removes limits from Scan operations when necessary for recovery and conjunction processing, ensuring all relevant records are considered before filtering.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a backport that refactors the logic for preparing Get and Scan operations for transaction reads and serializable validation into a new ConsensusCommitUtils class. This is a good improvement as it unifies the logic and reduces code duplication in CrudHandler and Snapshot. The changes are well-implemented, and the new utility class is thoroughly tested. I have one suggestion to improve the implementation.