Use CoreError for messages of RuntimeExceptions in DynamoAdmin

[brfrn169]

Description

This PR updates DynamoAdmin to use CoreError for messages of RuntimeExceptions.

Related issues and/or PRs

N/A

Changes made

• Updated DynamoAdmin to use CoreError for messages of RuntimeExceptions.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness and clarity of error handling within the DynamoAdmin component. By migrating from ad-hoc string messages to a standardized CoreError enum for RuntimeExceptions, the changes ensure more consistent and specific error reporting for DynamoDB-related operations, which aids in debugging and future development.

Highlights

• Error Message Standardization: Standardized RuntimeException messages in DynamoAdmin to use CoreError enum entries, improving consistency and maintainability.
• New CoreError Types: Introduced new CoreError types specifically for DynamoDB-related constraints and unsupported operations, such as BLOB/BOOLEAN type restrictions for keys/indexes and import functionality.
• Exception Handling Refinement: Refactored exception handling in DynamoAdmin for secondary index creation and import operations, including changing an IllegalStateException to ExecutionException.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR updates DynamoAdmin to use standardized CoreError messages instead of hardcoded strings for RuntimeExceptions, improving error consistency and maintainability.

Key Changes

• Replaced hardcoded error messages with CoreError enum constants for better standardization
• Added four new CoreError entries for DynamoDB-specific validation errors
• Changed exception type from IllegalStateException to ExecutionException for index waiting timeout

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
DynamoAdmin.java	Updated to use CoreError.buildMessage() for exception messages and changed exception types
CoreError.java	Added four new DynamoDB-specific error constants with standardized messages

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gemini-code-assist]

Code Review

This pull request is a good step towards standardizing error messages by using the CoreError enum. The changes in DynamoAdmin.java and the new error definitions in CoreError.java improve code maintainability and consistency. However, I've identified a high-severity issue in DynamoAdmin.java where a proper null check has been replaced by an assert statement. This could lead to NullPointerException in production environments and should be reverted to the original explicit null check.

[feeblefakie]

LGTM! Thank you!

[josh-wong]

I left just one minor suggestion. Other than that, LGTM. Thank you!🙇🏻‍♂️

[komamitsu]

LGTM! 👍

[brfrn169]

@Torch3333 @KodaiD I'll merge this PR. Please take a look when you are back!

[KodaiD]

@brfrn169 Should we do the same for the followings?

• https://github.com/scalar-labs/scalardb/blob/master/core/src/main/java/com/scalar/db/storage/cassandra/CassandraAdmin.java#L80
• https://github.com/scalar-labs/scalardb/blob/master/core/src/main/java/com/scalar/db/storage/cassandra/CassandraAdmin.java#L397

[brfrn169]

@brfrn169 Should we do the same for the followings?

• https://github.com/scalar-labs/scalardb/blob/master/core/src/main/java/com/scalar/db/storage/cassandra/CassandraAdmin.java#L80
• https://github.com/scalar-labs/scalardb/blob/master/core/src/main/java/com/scalar/db/storage/cassandra/CassandraAdmin.java#L397

@KodaiD Good catch! I'll handle those. Thanks!