Make some changes which hopefully increases the readability. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigpastro
commented
Oct 10, 2018
| For building Scalar DB, what you need to do to is pretty simple as follows. | ||
| ``` | ||
| $ cd /path/to/scalardb | ||
| $ ./gradlew installDist |
Contributor
Author
There was a problem hiding this comment.
Is this really gradlew?
Contributor
There was a problem hiding this comment.
yes, gradlew is correct.
feeblefakie
reviewed
Oct 10, 2018
Contributor
feeblefakie
left a comment
feeblefakie
left a comment
There was a problem hiding this comment.
I made some comments
docs/schema.md
Outdated
| * add `before_` prefixed values for each existing value except for primary keys (partition keys and clustering keys) for managing before image | ||
|
|
||
| Also, we need state table for managing transaction states as follows. | ||
| Additionally, we a need state table for managing transaction states as follows. |
Contributor
There was a problem hiding this comment.
You mean we need a, right ?
docs/getting-started.md
Outdated
| NOTICE: We are planning to have a Scalar DB specific schema definition and schema loader. | ||
|
|
||
| In this document, let's use the following Cassandra schema. | ||
| The following document ([`emoney-storage.cql`](getting-started/emoney-storage.cql)) specifies a Cassandra schema. |
Contributor
There was a problem hiding this comment.
I mean document for the whole document here.
Is it OK to remove document here ?
feeblefakie
approved these changes
Oct 10, 2018
Contributor
feeblefakie
left a comment
feeblefakie
left a comment
There was a problem hiding this comment.
LGTM ! Thank you very much !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@feeblefakie I don't think that there is any problem, but perhaps it would be a good idea to ensure that I didn't change the meaning of anything you wrote anywhere.