Changes made for compatibility with android gradle plugin 2.3.0 and Gradle 3.3, with Scala updated to 2.11.8. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; update Scala to 2.11.8.
|
What's the status of this PR? @xingda920813 I'm sorry that did you be aware of the Travis CI build result was failed, would you please help to fix it? I think this PR is very useful for others, looking forward to be merge to master ASAP. Thanks for you great work~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, saturday06.
I have made some changes to gradle-android-scala-plugin, for Gradle 3.0+ deleted useAnt option, which is deprecated in Gradle 2.x. Continue to use useAnt will prevent Gradle to compile, so I removed it and updated Gradle to 3.3.
I also updated Android Gradle Plugin to 2.3.0. From 2.2.0, it seems new version of the plugin only exists in jcenter, not in mavenCentral any more. So I changed the preferable repo to jcenter to retrieve new version of plugin.
Scala has been updated to 2.11.8, with some other dependencies updated.
I have run integTest on my local env and passed all the tests.