-
Notifications
You must be signed in to change notification settings - Fork 18
fix: new clippy warnings #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Technically, now when all clippy warnings are fixed, I can rollback other changes. |
|
Thanks @Vaiz , really appreciate the help 🥇
Yea I noticed, I would prefer to avoid mixing concerns in same PR, there are some unrelated to the clippy warnings , those might be better suited for a separate issue and PR. would you mind updating pr to have changes related to clippy warnings? (i.e c3c2557) If you revert other changes and only keep c3c2557 , will we have any build error? 🤔 |
done
clippy errors should be gone, but other issues, related to not working combinations of features, will remain |
|
Thanks @Vaiz , I will merge it once you resolve the conflicts other compilation error you mentioned , it does not happen normally when we run |
|
updated PR.
I encountered these error when I had tried to run |
hashemix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks so much for your contributions and quick responses! 🥇
📌 Summary
This PR fixes new clippy warnings. I also had to enable at least one schema by default, but I think it's a good change, and makes it easier to use the crate.
Sorry for mixed PR, these other issues were causing troubles when I tried to fix clippy warnings.
🔍 Related Issues
In PR #63 , ci is failing because of these new errors
✨ Changes Made
- added rust-mcp-sdk as dev-dependency to rust-mcp-macros- strategically placed#[cfg(any(feature = "2025_03_26", not(feature = "2024_11_05")))]in a few places to fix compilation errors- rust-mcp-transport is not optional anymore🛠️ Testing Steps
💡 Additional Notes